It is probably much harder to remove these deprecated expression from Maven than from a plugin. If plugins could participate in banning these expressions, I'd prefer to go that way.I'd prefer not to throw the NPE, but a (DeprecatedExpressionException extends?) MojoFailureException with a proper message. RobertDate: Fri, 30 Nov 2012 11:42:32 +0100 From: [email protected] To: [email protected] Subject: Re: [mojo-dev] What to do about ${parent.groupId} a.k.a. MVERSIONS-200
With the danger of coming out a little bit harsh, I think we're currently already doing too much work helping people doing the wrong thing. Why can't they just fix their projects? It's a deprecated thing and they are warned. I see so many projects with warnings filling the console and the users just don't care. It's about time they feel the pain of not fixing things... Also, if this would have been a core plugin then maybe this could have been something to handle, but being a mojo plugin I think you can be more strict. Very much my own 2 cents around pushing users to do the right thing and enable us write cleaner software and focus on the right things, /Anders On Fri, Nov 30, 2012 at 11:31 AM, Stephen Connolly <[email protected]> wrote: I am interested in other peoples thoughts with respect to https://jira.codehaus.org/browse/MVERSIONS-200 Basically, if you have the old deprecated expressions like ${parent.groupId} in your poms, then it blows up. My question is should I add support for these expressions (and then remove it again at some point in the future), or leave it blowing up and say "nah nah nah nah nah... you were warned... go fix your poms anyway". Don't really want to have a version of the plugin that won't work correctly with future versions of Maven, so adding support for expressions that may be removed in an unknown future version of Maven would not seem like a bad plan... on the other hand, users expect that if Maven builds it versions-maven-plugin can change the version! -Stephen
