Glen Mazza commented on Improvement MVERSIONS-207

Sorry, error on my part, I believe this patch needs to be reverted. The problem is in DisplayPluginUpdatesMojo's pluginsWithVersionsSpecified – this array (incorrectly) does not include plugin versions defined in parent-level POM <pluginManagement/> sections – only those contained in pM sections within the same pom being processed. Assume a plugin P in a child pom does not have a version number defined within its declaration. Before the patch, display-plugin-updates would complain that P's version is not defined if it is defined in a parent-level pom pluginManagement section (bug) and if it is not defined in a parent-level pom pM section (correct). With this patch, display-plugin-updates will not complain in either case, meaning (correct) and (bug), respectively instead. But "bug"/"correct" which results in annoying extra info being reported is still better than "correct"/"bug" which results in important information not being reported (i.e., a plugin version is truly not defined anywhere, and is instead being injected from whatever is in the user's local repo.)

It may be awhile before I can come up with an adequate patch for this problem as hierarchical POM-parsing logic is not easy. If someone else who knows the code better can get this done, fantastic.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email

Reply via email to