If you're already rolling the vote you could do this later. But we should file a ticket in that case. (Or fix it on trunk right away)
I just noticed that you're using "target directory" and "output directory" in the docs. You should settle on one term. I did some smaller changes in the usage page to align that page on target directory. BUT, the term normally used is output directory and you should change the text to this instead and also change the config param. This could call for cancelling the alpha-1 you're preparing, but as it is an alpha it could also change in alpha-2. It's your call. /Anders On Thu, Mar 28, 2013 at 12:46 PM, Baptiste MATHUS <[email protected]>wrote: > Good idea. I must admit I copied it from the resource-plugin initially as > an example, and I then left it because it was also applicable to the > templating-maven-plugin. > But I agree this could/should be just removed or adjusted. > > As the new release is already being pushed for alpha-1, do you think this > improvement should go into alpha-1 or could it wait for say the alpha-2 (or > even fixing the doc before releasing, I seem to remember this was admitted > practice in some cases)? I'd prefer to know if this will directly yield a > -1 before calling a vote :-). > > Thanks > > > 2013/3/28 Anders Hammar <[email protected]> > >> >> I'm wondering about the encoding example. Would you EVER want to do this? >>> I mean, you need to configure the compiler plugin with the same encoding so >>> specify project.build.sourceEncoding is the way to go IMO. You could keep >>> the possibility to configure this, but I don't see the value in having an >>> example of (what I think would be) an anti-pattern. >>> >> >> Thinking this through I think that the example could be kept, but you >> should change it to show the proper usage of the >> project.build.sourceEncoding property to configure this. >> >> /Anders >> >> >> >>> >>> /Anders >>> >>> >>> On Thu, Mar 28, 2013 at 12:36 PM, Baptiste MATHUS <[email protected]>wrote: >>> >>>> Fixed, thanks. >>>> >>>> >>>> 2013/3/28 Stephen Connolly <[email protected]> >>>> >>>>> >>>>> http://mojo.codehaus.org/templating-maven-plugin/examples/source-filtering.htmlhas >>>>> the defaults in the example as children of <goals> and not >>>>> <configuration> >>>>> >>>>> >>>>> On 27 March 2013 22:01, Baptiste MATHUS <[email protected]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I'd like to release version 0.0.1 of the templating-maven-plugin >>>>>> >>>>>> That project was created to offer the Maven Right Way® to filter >>>>>> sources. >>>>>> >>>>>> This is the very* first release* of this recently graduated mojo. >>>>>> That's why I chose a 0.0.1 versioning as a starting point. >>>>>> >>>>>> Staging Repositories: >>>>>> General: https://nexus.codehaus.org/content/groups/staging/ >>>>>> Exclusive: >>>>>> https://nexus.codehaus.org/content/repositories/orgcodehausmojo-003/ >>>>>> >>>>>> (Staging) Site: >>>>>> http://mojo.codehaus.org/templating-maven-plugin/ >>>>>> >>>>>> SCM Tag: >>>>>> https://svn.codehaus.org/mojo/tags/templating-maven-plugin-0.0.1 >>>>>> >>>>>> We also plan to add some day support for templating engines like >>>>>> Mustache, ... >>>>>> >>>>>> [ ] +1 >>>>>> [ ] +0 >>>>>> [ ] -1 >>>>>> >>>>>> The vote is open for 72 hours and will succeed by lazy consensus. >>>>>> >>>>>> Cheers >>>>>> >>>>>> -- Baptiste >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Baptiste <Batmat> MATHUS - http://batmat.net >>>> Sauvez un arbre, >>>> Mangez un castor ! >>>> >>> >>> >> > > > -- > Baptiste <Batmat> MATHUS - http://batmat.net > Sauvez un arbre, > Mangez un castor ! >
