True. Maybe the scope became unessecary big when this parameter was added.
It might have been enough if the plugin would have produced only noarch
rpms.

Maybe we should have a review of the capabilities of the plugin and make a
list of changes that we should make for next major version where we can
require the users to change their configuration (in other words - break
backward compatibility).

// Rickard


On Sun, May 12, 2013 at 7:24 PM, Brett Okken <brett.okken...@gmail.com>wrote:

> Even so, consumers of the plugin should, as with all plugins, attempt to
> be as independent of build system as possible. The needArch option should
> never have existed as a boolean. It should always have been a string value
> where the specific value to use was provided explicitly. The fact that the
> default value ascertained does not work for every case should serve as
> encouragement to loosen the coupling to the buildsystem and configure the
> desired value directly.
>  On May 12, 2013 7:53 AM, "Rickard von Essen" <rickard.von.es...@gmail.com>
> wrote:
>
>> Since the rpm-plugin can't do anything without rpm-build installed I
>> disagree. The rpm-plugin should work under cygwin, but as long as we don't
>> have any serious java-only rpm library I don't see any point on trying to
>> avoid to depend on rpm. Especially when the result is incorrect.
>>
>> If we would like to get away from the dependency of the rpm tool we
>> should start building an rpm lib. This is something that will require allot
>> of time to build and I'm not sure if we will gain much from it. Probably
>> it's better to spend time on verifying that it works correctly in cygwin.
>>
>> Regards
>> // Rickard
>>
>>
>> On Sun, May 12, 2013 at 2:09 PM, Brett Okken <brett.okken...@gmail.com>wrote:
>>
>>> I thought the goal was to become less dependent on the rpm cli so that
>>> the plugin could eventually run anywhere (including windows). Both changes
>>> proposed here make that more difficult to achieve.
>>>  On May 4, 2013 11:12 AM, "Rickard von Essen (JIRA)" <j...@codehaus.org>
>>> wrote:
>>>
>>>>        Rickard von 
>>>> Essen<https://jira.codehaus.org/secure/ViewProfile.jspa?name=rickard.v.essen>updated
>>>>  [image:
>>>> Bug] MRPM-119 <https://jira.codehaus.org/browse/MRPM-119>
>>>>  *Wrong detection of system 
>>>> architecture*<https://jira.codehaus.org/browse/MRPM-119>
>>>>
>>>> Updated patch using "rpm -E %{_arch}" to determine the architecture of
>>>> the system.
>>>>    *Change By:*  Rickard von 
>>>> Essen<https://jira.codehaus.org/secure/ViewProfile.jspa?name=rickard.v.essen>(04/May/13
>>>>  11:10 AM)
>>>> *Attachment:*  MRPM-119_svn-v2.patch       This message is
>>>> automatically generated by JIRA.
>>>> If you think it was sent incorrectly, please contact your JIRA
>>>> administrators
>>>> For more information on JIRA, see:
>>>> http://www.atlassian.com/software/jira
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe from this list, please visit:
>>>> http://xircles.codehaus.org/manage_email
>>>
>>>
>>

Reply via email to