[mojo-dev] [jira] (MASPECTJ-110) Don't add nonexistent sourceDirectory

[Lennart Jorelid (JIRA)]

Lennart Jorelid edited a comment on MASPECTJ-110 Don't add nonexistent sourceDirectory This is still a blocker for quite a few downstream plugins. If we are considering releasing a new version of the aspectj plugin anytime soon, it is really necessary to include a patch of this one. The compileSourceRoot is modified (by adding the Aspect paths) for plugins running after the AspectJ Maven Plugin. The src/main/aspect is not defined as part of the compileSourceRoots in the POM of the project - and despite this, the src/main/aspect is incorrectly added (twice!) to the compileSourceRoots by the AspectJ Maven Plugin. Since this directory is not present in the project, plugins following the AspectJ maven plugin crash on this nonexistent directory. Maven Debug Downstream from the AspectJ Maven Plugin [DEBUG] (f) compileSourceRoots = [/Users/lj/Development/TestProject/service/document/document-model/src/main/java, /Users/lj/Development/TestProject/service/document/document-model/src/main/aspect, /Users/lj/Development/TestProject/service/document/document-model/src/main/aspect] From the code below, it seems that the plugin simply adds the aspectDirectory and testAspectDirectory to the project compile and test compile source roots, respectively. ... but these temporary additions for AspectJ compilation must either be removed when the aspect compilation is done (and it seems they are not) or not be added if either the aspectDirectory and testAspectDirectory do not exist. AbstractAjcCompiler.java project.getCompileSourceRoots().add( FileUtils.resolveFile( basedir, aspectDirectory ).getAbsolutePath() ); project.getTestCompileSourceRoots().add( FileUtils.resolveFile( basedir, testAspectDirectory).getAbsolutePath() );

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email