I fixed item 2 and 3 in 1.8-SNAPSHOT.
On Mon, Dec 16, 2013 at 9:33 AM, Dan Tran <dant...@gmail.com> wrote: > Hi Dennis, > > Thank you for feedback. > > 1. Could we add this as a release note or at the plugin configuration? I > believe most user already has this configured in their pom, and the change > is minor and obvious IMO > > 2. will do > > 3. This is my fault. It fails on unix and I just forgot about it. Will fix > it > > Thanks > > -D > > > On Mon, Dec 16, 2013 at 7:21 AM, Dennis Lundberg <denn...@apache.org>wrote: > >> Hi, >> >> Sorry for being mostly absent from the list for a while. >> >> I've done a brief review of the code changes for this release, and I >> have a few things that I feel should be fixed before making the 1.7 >> release (due to MAPPASM-210): >> >> 1. The backward incompatible change of the default value for >> configurationDirectory in generate-daemons isn't really needed to do >> the other stuff. I feel that we should keep backward compatibility >> here, because we have previously gone to considerable lenghts to do >> so. >> >> 2. The @since information for the parameters need to be revised after >> being moved to AbstractScriptGeneratorMojo, because the since value is >> different for the inheriting mojos. Have a look at the parameter >> useWildcardClassPath for how we have done this before. >> >> 3. One unit test in ScriptGeneratorTest has been disabled by renaming >> it to blahTestNormalShellScriptWithEndorsedLibGeneration(). Was this >> intentional or just something that was forgotten before committing? I >> tried locally to rename it back again, and all the unit tests pass for >> me on Windows. >> >> What are your thoughts on these? >> >> >> On Sat, Dec 14, 2013 at 4:13 PM, Karl Heinz Marbaise <khmarba...@gmx.de> >> wrote: >> > Hi, >> > >> > I'd like to release version 1.7 of the appassembler-maven-plugin >> > >> > The Application Assembler Plugin is a Maven plugin for generating >> > scripts for starting java applications. >> > All dependencies and the artifact of the project itself are placed in >> > a generated Maven repository in a defined assemble directory. >> > All artifacts (dependencies + the artifact from the project) are added >> > to the classpath in the generated bin scripts. >> > >> > We solved five issues: >> > >> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11780&version=19642 >> > >> > There are still a couple of issues left in JIRA: >> > >> http://jira.codehaus.org/issues/?jql=project%20%3D%20MAPPASM%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20ASC%2C%20priority%20DESC >> > >> > Staging Repositories: >> > General: https://nexus.codehaus.org/content/groups/staging/ >> > Exclusive: >> > https://nexus.codehaus.org/content/repositories/orgcodehausmojo-1039/ >> > >> > (Staging) Site: >> > http://mojo.codehaus.org/appassembler/appassembler-maven-plugin/ >> > >> > SCM Tag: >> > http://svn.codehaus.org/mojo/tags/appassembler-1.7 >> > >> > ADDITIONAL_INFORMATION >> > >> > [ ] +1 >> > [ ] +0 >> > [ ] -1 >> > >> > The vote is open for 72 hours and will succeed by lazy consensus. >> > >> > Kind Regards >> > Karl-Heinz Marbaise >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe from this list, please visit: >> > >> > http://xircles.codehaus.org/manage_email >> > >> > >> >> >> >> -- >> Dennis Lundberg >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> >> >
