Hi,
I don't mind the Maven 2.2.1 requirement, that's good. Especially since
2.1.0 and 2.2.0 are broken versions of Maven. This will force them to
avoid these Maven versions.
I'm aware that the 1.5 has reach EOL, but still a lot a companies use it.
The bigger the company, the harder it is to upgrade. In this case I'm
especially thinking of webservers which are used for continuous
integration.
The next of Apache Maven will be the first one which will require Java
1.6. If it is not necessary for the plugin to use 1.6, I'd keep it on 1.5
for a while. For the syntax the only important missing feature I can think
of is the @Override of interface methods. I'm not sure if it is worth it
to require 1.6 for this.
Robert
Op Tue, 31 Dec 2013 13:53:33 +0100 schreef Rickard von Essen
<[email protected]>:
Hi,
Yes I realise I changed the build to use Java 1.6. But that was my point.
If we only build and test the plugin with 1.6/2.2.1 we will not be sure
that it works for 1.5/2.0.6. Since maven recommends 2.2.1 if you don't
need
Java 1.4 compat, and Java 1.5 is nearly 10 years old and was EOL 4 years
ago. I thought it was about time to drop (official) support for those.
If someone objects to the dropping support for Maven 2.0.6 and Java 1.5
in
rpm-maven-plugin 2.1-alpha-4 I'm open for a discussion.
Also see http://jira.codehaus.org/browse/MRPM-140
// Rickard von Essen
On Tue, Dec 31, 2013 at 1:26 PM, Robert Scholte
<[email protected]>wrote:
Hi,
"Running IT's requires Maven 2.2.1 and Java 1.6"
This is not exactly how it works.
Now you have defined it for the build as well, not only the ITs.
Better is to configure the maven-invoker-plugin, preferred an
invoker.properties per test like:
invoker.maven.version = 2.2.1+
invoker.java.version = 1.6+
See http://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#
invokerPropertiesFile
Robert
Op Tue, 31 Dec 2013 13:20:14 +0100 schreef
<[email protected]>:
Revision:
19160
Author:
rickard.v.essen
Date:
2013-12-31 06:20:11 -0600 (Tue, 31 Dec 2013)
Log Message
[MRPM-151] Running IT's requires Maven 2.2.1 and Java 1.6
Added requirements
- Maven 2.2.1
- Java 1.6
and dependency:
- org.codehaus.plexus:plexus-interpolation:1.13
Modified Paths
trunk/mojo/rpm-maven-plugin/pom.xml
Diff
Modified: trunk/mojo/rpm-maven-plugin/pom.xml (19159 => 19160)
--- trunk/mojo/rpm-maven-plugin/pom.xml 2013-12-31 08:51:21 UTC
(rev 19159)
+++ trunk/mojo/rpm-maven-plugin/pom.xml 2013-12-31 12:20:11 UTC
(rev 19160)
@@ -88,6 +88,9 @@
</contributor>
<contributor>
<name>Rickard von Essen</name>
+ <email>[email protected]</email>
+ <organization>Diabol AB</organization>
+ <organizationUrl>http://www.diabol.se</organizationUrl>
<roles>
<role>Java Developer</role>
</roles>
@@ -135,6 +138,11 @@
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-interpolation</artifactId>
+ <version>1.13</version>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-archiver</artifactId>
<version>2.1.2</version>
</dependency>
@@ -146,7 +154,8 @@
</dependencies>
<properties>
- <mavenVersion>2.0.6</mavenVersion>
+ <mavenVersion>2.2.1</mavenVersion>
+ <mojo.java.target>1.6</mojo.java.target>
</properties>
<reporting>
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
