hi Dipanjan It makes sense to keep the same goal, if filelist is a directory, the backend will generated the list.
Thank you for looking into this enhancement -Dan On Wed, Mar 26, 2014 at 2:49 AM, Dipanjan Laha <dipanja...@gmail.com> wrote: > Hi Dan, > > Will do as suggested. I had one question, regarding the new supported > type, should I create a new goal for the Plugin or should I add a flag in > the config of fileilst-upgrade goal which would enable this behavior. In > case we create a new goal, what should I name it? IMHO I feel that it would > be clean to add a new goal. Let me know what you think. > > Regards > Dipanjan > > > On Tue, Mar 25, 2014 at 8:20 PM, Dan Tran <dant...@gmail.com> wrote: > >> Hi Dipanjan >> >> 1. Yes documentation definitely needs help >> >> 2. Good idea, we can introduce one more supported type. >> >> Please files jira against dbupgrade component and patch with unit test. >> >> Very much appreciate the help >> >> -D >> >> >> On Tue, Mar 25, 2014 at 4:13 AM, Dipanjan Laha <dipanja...@gmail.com>wrote: >> >>> Hi Dan, >>> >>> I tested DB Upgrade with the filelist-upgrade goal and it worked very >>> well for me. I do have some feedback. >>> >>> 1. I found the documentation on the usage page to be bit old, less >>> verbose and incorrect at certain places. For example, if we specify the >>> configuration inside the execution tags(as shown in the usage page), then a >>> <id>default-cli</id> needs to be present, otherwise the config won't be >>> associated as the goal is directly invoked from command line (see >>> https://maven.apache.org/guides/mini/guide-default-execution-ids.html). >>> It would also be great to have an example with the SQLExec parameters >>> also specified. >>> >>> 2. IMHO I feel that we can have a way of executing the script files >>> without a file list. The files in a directory can be picked in a >>> lexicographical order and executed. The directories can also be ordered >>> in a similar way. That way a file list need not be explicitly maintained if >>> the file names are in order. >>> >>> Let me know your thoughts on these. If you feel they are valid, I can >>> work on them and submit a patch. >>> >>> Regards >>> Dipanjan >>> >>> PS: I feel that this is a really helpful plugin, if there is any way >>> to publicize this, we should. It can benefit many. >>> >>> >>> >>> On Mon, Mar 24, 2014 at 10:05 PM, Dan Tran <dant...@gmail.com> wrote: >>> >>>> Please do, >>>> >>>> It is currently working out very well for me. >>>> >>>> Thanks >>>> >>>> -Dan >>>> >>>> >>>> On Mon, Mar 24, 2014 at 9:20 AM, Dipanjan Laha <dipanja...@gmail.com>wrote: >>>> >>>>> Hi Dan, >>>>> >>>>> Then I can try it out in our build process. If you have plans to take >>>>> it forward or improve it, let me know, i will try and help in whatever way >>>>> I can :) >>>>> >>>>> Regards >>>>> Dipanjan >>>>> >>>>> >>>>> On Monday, March 24, 2014, Dan Tran <dant...@gmail.com> wrote: >>>>> >>>>>> Hi Dipanjan >>>>>> >>>>>> It is not in dormant state. Just quietly waiting for feedback :-) >>>>>> >>>>>> -D >>>>>> >>>>>> >>>>>> On Mon, Mar 24, 2014 at 2:38 AM, Dipanjan Laha >>>>>> <dipanja...@gmail.com>wrote: >>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> I wanted to enquire about the current state of the DBUpgrade maven >>>>>>> Plugin. I saw that there has been no activity on this since January >>>>>>> 2012. >>>>>>> Is this project in dormant state or would there be more development on >>>>>>> this? >>>>>>> I find this to be an extremely useful plugin to have and would like >>>>>>> to contribute and improve this in case there are plans to have further >>>>>>> releases of this plugin. >>>>>>> >>>>>>> Regards >>>>>>> Dipanjan >>>>>>> >>>>>> >>>>>> >>>> >>> >> >
