Am 24.05.2014 12:03, schrieb Robert Scholte:
Hi,
Hi Robert,
seems like I missed a mail.
no worries...
What I don't understand is why you want to overcomplicate things by using KeepOrAdd (and what would the value of add be?), KeepIfExist and remove. I'd prefer to just naming those elements you'd like to copy, warn if the element is not there.There is a difference between inherited elements and those taken from the actual POM. I assume that flatten-maven-project is used by large multi-module-builds. Typically you will have one "policy" how flattening shall happen that is defined in your parent POM. Then maybe some child modules will explicitly define POM elements such as url, issueManagement, etc. that should be be deployed while child modules that do not contain such elements shall be deployed without these elements that would otherwise be inherited. Also for name "keepOrAdd" will add a default value (artifactId) while "keepIfExists" would not. Might be that I see things complicated. And if all others agree, I might drop this but... ...what would be the value in your case? "add" or "remove"? Or where you saying that one should list the element names as a single String in a comma separated list? IMHO the default use-case will be that someone will choose a predefined descriptor and just needs one line such as <flattening>OSSHR</flattening>. But if someone decides to configure the "descriptor" individual at all this might be a very specific situation and then why not giving all the flexibility I already implemented? Unlike a comma separated list, this approach is also extensible for upcoming requests...
I'll give it a the next couple of days. thanks, Robert
Thanks Jörg
smime.p7s
Description: S/MIME Cryptographic Signature
