[mojo-dev] [jira] (MVERSIONS-123) Version properties inparent not picked up by e.g. display-property-updates

[Stephen Connolly (JIRA)]

Title: Message Title

Stephen Connolly commented on an issue   Re: Version properties inparent not picked up by e.g. display-property-updates One has an option to introduce a local property in B, thus overriding the inherited value. And as soon as you add the property override to B then the plugin should start showing updates for that property... and if it isn't then that is a bug. This is like the difference between versions:set acting on the parent of the following two poms <project> <parent> <groupId>local</groupId> <artifactId>parent</artifactId> <version>1.0-SNAPSHOT</version> </parent> <artifactId>child-a</artifactId> </project> <project> <parent> <groupId>local</groupId> <artifactId>parent</artifactId> <version>1.0-SNAPSHOT</version> </parent> <artifactId>child-b</artifactId> <version>1.0-SNAPSHOT</version> </project> When versions:set is run against local:parent:1.0-SNAPSHOT then both child projects will have their /project/parent/version updated. child-b, by providing an explicit /project/version value is indicating the intent that it should not be versioned in lock step with the parent. I appreciate that it can be confusing to understand why the plugin makes the inferences that it does... but in general the principle is that if you have repeated something that you don't need to repeat then that indicates the repetition is important to you. So now we get to what should you be doing? Well if you are defining the version of a single dependency, you should not use a property to control it (except for the very rare case where you want to test different versions of the dependency quickly from the CLI... but that is rare) So the correct case to use a property is where you have multiple dependencies that must be kept in lock step. You are asking for errors if you don't handle that with a dependencyManagement in the same pom as where the property is defined... so while I view it as a bug that the parent does not check the child projects from the reactor for use of the property, it is not really a fixable bug as there is no way to guarantee - from the parent - that its only children are those within the reactor... a better way to handle this is to view projects that explicitly use a property inherited from their parent, rather than having the dependency management inherited, as being stylistically incorrect. This plugin is opinionated. Its opinion is that you did not specify any properties in the pom and thus there are no properties in the pom to update... I think - unchecked - that you could indicate your intent by adding ... <properties> <foo.version>${foo.version}</foo.version> ... </properties> ... in other words by indicating that the property's default value is the same as the parents but you want the option to change from the default Add Comment   Mojo's Versions Maven Plugin / MVERSIONS-123 Version properties inparent not picked up by e.g. display-property-updates The goals operating on *property* controlled version numbers (e.g. display-property-updates) only work if the properties are defined in the targeted POM itself, not in a parent POM. Example: If module *B* has a dependency on module A, declared in B as follows: <dependency> <groupId>com.my.test</groupId> <artifactId>module-A</artifactId> <ve... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email