[mojo-dev] [jira] (MAPPASM-129) Handle path with space for generated script on unix

[Alvin Lim (JIRA)]

Title: Message Title

Alvin Lim commented on an issue   Re: Handle path with space for generated script on unix I see this is due to the implementation of org.codehaus.mojo.appassembler.daemon.script.Platform.getExtraJvmArguments(). Specifically, it's due to the usage of the arrayToString() method on lines 396 and 397when formatting each VM argument. public String getExtraJvmArguments( JvmSettings jvmSettings ) throws IOException { if ( jvmSettings == null ) { return ""; } String vmArgs = ""; vmArgs = addJvmSetting( "-Xms", jvmSettings.getInitialMemorySize(), vmArgs ); vmArgs = addJvmSetting( "-Xmx", jvmSettings.getMaxMemorySize(), vmArgs ); vmArgs = addJvmSetting( "-Xss", jvmSettings.getMaxStackSize(), vmArgs ); vmArgs += arrayToString( convertArguments( jvmSettings.getExtraArguments() ), "" ); vmArgs += arrayToString( jvmSettings.getSystemProperties(), "-D" ); return vmArgs.trim(); } private String arrayToString( List strings, String separator ) { String string = ""; if ( strings != null ) { Iterator it = strings.iterator(); while ( it.hasNext() ) { String s = (String) it.next(); if ( s.indexOf( ' ' ) == -1 ) { string += " " + separator + s; } else { string += " \"" + separator + s + "\""; } } } return string; } The arrayToString() method indiscriminately surrounds each argument with double quotes whenever a space is detected, due to the following code snippet: if ( s.indexOf( ' ' ) == -1 ) { string += " " + separator + s; } else { string += " \"" + separator + s + "\""; } Are additional double quotes necessary at this point? The VM arguments are referenced only when populating the value of the cmd variable, which already surrounds its contents with double quotes. It looks like this issue can be fixed by removing or rewriting the arrayToString() method so that no longer introduces additional double quotes. Add Comment   Mojo's AppAssembler Maven Plugin / MAPPASM-129 Handle path with space for generated script on unix This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email