[mojo-dev] [jira] (MLICENSE-104) update-file-header adds extra space

[Peter Palaga (JIRA)]

Title: Message Title

Peter Palaga commented on an issue   Re: update-file-header adds extra space +1 for considering this a valid bug. Let me try to explain the background in other words once again: Leaving whitespace at the end of a line is generally a bad coding practice that typically causes redundant noise in the given file's history. Although project maintainers can recommend particular IDE settings so that contributors can avoid trailing spaces, the maintaners never can have the contributors' IDEs fully under their control. As a consequence of that, contributors sometimes (unintentionally) commit changes with trailing spaces. Using maven-checkstyle-plugin or similar for checking that files do not contain trailing spaces is a common countermeasure. Note that this kind of checkstyle check can be applied to any text file, not only Java. Clearly, headers containing trailing spaces added by update-file-header goal, are seen as invalid code by maven-checkstyle-plugin and it is the license plugin that should be fixed. Add Comment   Mojo's License Maven Plugin / MLICENSE-104 update-file-header adds extra space I think it is an error to add extra spaces at the end of the comment prefix, by default for Java this is ' * ' with a space before and after. This means that any licenses with blank lines will have an empty space at the end. Many environments have checkstyle / IDE automatic removal of spaces at end of lines, thereby triggering a war between license-m-p an... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email