[mojo-dev] [jira] (MFINDBUGS-208) Command-line output does not give specific line number

[Konrad Windszus (JIRA)]

Title: Message Title

Konrad Windszus commented on an issue   Re: Command-line output does not give specific line number I don't really get the explanation here: The check mojo already parses the generated findbugs.xml (https://github.com/gleclaire/findbugs-maven-plugin/blob/master/src/main/groovy/org/codehaus/mojo/findbugs/FindbugsViolationCheckMojo.groovy#L508 ff). It is just that the parsing mechanism is not sophisticated enough to print out precise line information. It just evaluates the SourceLine within the Class element, but the more precise information is in the sibling SourceLine elements directly within the BugInstance element. Compare also with the XML at http://www.sw-engineering-candies.com/blog-1/howtotransformtheresultsfromfindbugscheckstyleandpmdintoasinglehtmlreportwithxslt20andjava#TOC-XML-from-Findbugs-Checkstyle-and-PMD- So just replacing log.info( bug.LongMessage.text() + FindBugsInfo.BLANK + bug.Class.'@classname' + FindBugsInfo.BLANK + bug.Class.SourceLine.Message.text() ) (https://github.com/gleclaire/findbugs-maven-plugin/blob/master/src/main/groovy/org/codehaus/mojo/findbugs/FindbugsViolationCheckMojo.groovy#L520) with log.info( bug.LongMessage.text() + FindBugsInfo.BLANK + bug.SourceLine.'@classname' + FindBugsInfo.BLANK + bug.SourceLine.Message.text() ) should give much more precise information. Add Comment   Mojo's FindBugs Maven Plugin / MFINDBUGS-208 Command-line output does not give specific line number github.com/jenkinsci/support-core-plugin @db48bb0 {code:none} --- findbugs-maven-plugin:3.0.0:check (default) @ support-core --- BugInstance size is 1 Error size is 0 Total bugs: 1 Possible null pointer dereference in com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(PrintWriter) due to return value of called method ["com.cloudb... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email