[ 
https://issues.apache.org/jira/browse/MRUNIT-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brock Noland updated MRUNIT-116:
--------------------------------

    Fix Version/s: 0.9.1
    
> Setting of configuration on Mappers/Reducers in MapDriver and ReduceDriver is 
> inconsistent
> ------------------------------------------------------------------------------------------
>
>                 Key: MRUNIT-116
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-116
>             Project: MRUnit
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Dave Beech
>            Assignee: Dave Beech
>            Priority: Minor
>             Fix For: 1.0.0, 0.9.1
>
>
> In the run methods of MapDriver and ReduceDriver (mapred API), the calling of 
> setConf and configure is inconsistent. 
> The check for instanceof Configurable and the call to setConf is missing from 
> ReduceDriver. 
> I suggest we replace these configuration checks and sets with a call to 
> Hadoop's ReflectionUtils.setConf, since this method contains the logic to 
> decide what to set where, based on whether the object is Configurable or 
> JobConfigurable etc. It also handles the proposed deprecation of JobConf, so 
> we wouldn't have to worry about that later. 
> Unless anybody has objections, I'll commit this change. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to