Hi Dave, I think you're right, until the old API is properly deprecated it is best to continue supporting both API's in MRUnit.
I'll copy the changes into mapred too. Cheers, James. On Mon, Jul 30, 2012 at 12:24 PM, Dave Beech <dbe...@apache.org> wrote: > I'm still using the old API for most of my mapreduce jobs - we used to use > Apache Hadoop 0.20.1 and the new API was embarrassingly incomplete and > buggy. I'm aware that a lot of the missing features (MultipleInputs etc) > have since been added in later versions but I've stuck with the old because > I trust it more. > > Until the old API is killed off by Hadoop - and I don't mean the > half-hearted deprecation that was reverted in the 0.21 branch - I think we > should continue to fully support it on mrunit too. > > Cheers, > Dave > > On 30 July 2012 09:30, James Kinley (JIRA) <j...@apache.org> wrote: > >> >> [ >> https://issues.apache.org/jira/browse/MRUNIT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424751#comment-13424751] >> >> James Kinley commented on MRUNIT-64: >> ------------------------------------ >> >> Agree on the javadoc, I will add this. >> >> I'd hope that the majority are using the new api by now, and going forward >> mapred will be phased out, so didn't think it was necessary to add it to >> the old api too. >> >> inputs is initialised in the base class so should never be null. I have >> added the check to the MapDriver so will also add it here for consistency. >> >> Thanks for the feedback. >> >> > Multiple Input Key, Value Pairs should be supported >> > --------------------------------------------------- >> > >> > Key: MRUNIT-64 >> > URL: https://issues.apache.org/jira/browse/MRUNIT-64 >> > Project: MRUnit >> > Issue Type: New Feature >> > Affects Versions: 0.8.1 >> > Reporter: Brock Noland >> > Assignee: James Kinley >> > Fix For: 1.0.0 >> > >> > Attachments: MRUNIT-64-v1.patch, MRUNIT-64.patch >> > >> > >> > The comments on MRUNIT-14 brought up a great point. The API today only >> allows a single key value pair input. In many scenarios multiple inputs >> would be useful. >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> >>
