[ 
https://issues.apache.org/jira/browse/MRUNIT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Beech updated MRUNIT-127:
------------------------------

    Attachment: MRUNIT-127.patch

Guys, can I get a quick review on this patch please? 

It does introduce two unit test failures (testComparators in 
TestMapReduceDriver, mapred and mapreduce versions), but actually I think 
that's because those tests use the same incorrect assumptions that this JIRA is 
meant to fix. 

I'll run that test as a true MapReduce job to see if it confirms my suspicions 
and report back. 
                
> Key grouping with GroupingComparators is not consistent with MapReduce 
> behaviour
> --------------------------------------------------------------------------------
>
>                 Key: MRUNIT-127
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-127
>             Project: MRUnit
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Dave Beech
>            Assignee: Dave Beech
>             Fix For: 1.0.0
>
>         Attachments: MRUNIT-127.patch
>
>
> In Hadoop MapReduce, for a set of keys to be properly grouped together by a 
> grouping comparator into a reduce call, they need to be in a contiguous range 
> when sorted by the key's ordering comparator. 
> MRUnit does not impose this requirement, so if the user's grouping and 
> sorting comparator logic is incorrect, their tests may pass and give the 
> expected result even though the outcome would be different when run as a true 
> MapReduce job. 
> (see below for further explanation)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to