[
https://issues.apache.org/jira/browse/MRUNIT-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433030#comment-13433030
]
Dave Beech commented on MRUNIT-140:
-----------------------------------
Bertrand - nice work. This is a great idea and the patch looks good overall.
Couple of points:
- Don't forget the Apache header on the new Errors class
- Maybe do the grammar corrections on the counter error messages separately?
Just so we keep the commits to a single issue each.
- I'm not sure we need to retain the delegating "formatValueList" method in
TestDriver. Something to discuss...
As for using Guava to do the string join - I know MRUnit used to have it as a
dependency but this was removed in MRUNIT-50. Probably not worth bringing it
back for such a simple method.
> TestDriver should use composition and have less responsilibities
> ----------------------------------------------------------------
>
> Key: MRUNIT-140
> URL: https://issues.apache.org/jira/browse/MRUNIT-140
> Project: MRUnit
> Issue Type: Task
> Reporter: Bertrand Dechoux
> Priority: Minor
> Attachments: mrunit-errors.diff
>
>
> Due to more and more (welcomed) refactorings, TestDriver is becoming bigger
> and bigger. Reducing code duplication is a good thing. But TestDriver begins
> to have too many responsibilities. A solution would be to use composition in
> order to extract responsibilities from it.
> I currently see a few topics that could profit from it:
> * Errors recording
> * Distributed Cache
> * Counter validation
> You are welcome to suggest more. This work might in the end also help with
> the implementation of the new API by providing a cleaner internal
> organisation of MRUnit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
