[ 
https://issues.apache.org/jira/browse/MRUNIT-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brock Noland updated MRUNIT-167:
--------------------------------

    Attachment: MRUNIT-167-1.patch

Patch v2 minor removal of unneeded code.

The one thing I am not completely sure of is in MockMapreduceOutputFormat are 
we using inputFormatJob appropriately. I believe it's uses to read the output 
of the job back in so I wonder if this line:

    taskAttemptContext.getConfiguration().set(FileInputFormat.INPUT_DIR, 
        new Path((outputPath + "/*/*/*/*")).toString());

shouldn't be using that configuration object instead.
                
> context passed to an OuputFormatter is ignored by the framework
> ---------------------------------------------------------------
>
>                 Key: MRUNIT-167
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-167
>             Project: MRUnit
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Patrick Hunt
>            Priority: Blocker
>             Fix For: 1.0.0
>
>         Attachments: MRUNIT-167-0.patch, MRUNIT-167-1.patch
>
>
> The following method creates a context that it passes to the output formatter 
> under test, however it ignores the results:
> bq. 
> org.apache.hadoop.mrunit.internal.mapreduce.MockMapreduceOutputFormat.collect(K,
>  V)
> specifically if the output formatter increments counters the counters are not 
> available to the test code. (DummyReporter just creates a new Counter() each 
> time) In my case I'm incrementing counters in my output formatter but these 
> counters are not available when I check in my junit test method at the end of 
> the test run.
> I'm using the latest 1.0.0 snapshot with hadoop2 classifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to