Ignore my comment about NOTICE.txt. Guess I didn't check the JIRA very closely for MRUNIT-210 ....
Thanks, Dave On 3 June 2014 11:06, Dave Beech <dbe...@apache.org> wrote: > +1 > > * Built both source distros on Ubuntu and OSX, Maven 2 and 3 - all fine, > tests pass > * Verified all checksums and sigs > > To add to Jarcec's comment about licenses - does our NOTICE.txt contain > everything it should? I'm not so clear about the rules for what should and > shouldn't be notified. > > Also, we have some Javadoc warnings during the build so i'll create a JIRA > to fix those. > > Cheers, > Dave > > > > On 2 June 2014 23:23, Brock Noland <br...@cloudera.com> wrote: > >> ping >> >> >> On Thu, May 29, 2014 at 10:19 AM, Brock Noland <br...@cloudera.com> >> wrote: >> >> > +1 >> > >> > * Tests pass >> > * sigs/hashes match >> > >> > I created https://issues.apache.org/jira/browse/MRUNIT-210 to track the >> > issue Jarcec mentions. >> > >> > >> > On Tue, May 27, 2014 at 6:29 PM, Jarek Jarcec Cecho <jar...@apache.org> >> > wrote: >> > >> >> +1 >> >> >> >> * Tests passes >> >> * Checked signatures and checksums >> >> * Checked jars in binary artifacts for licenses >> >> >> >> The only small nit is that we have special entires in LICENSE.txt for >> >> some jars that we are shipping in the binary release but not for all of >> >> them. I think we should add those entries there, but I don't consider >> this >> >> one as a release stopper. >> >> >> >> Jarcec >> >> >> >> On Tue, May 27, 2014 at 05:10:19PM -0700, Brock Noland wrote: >> >> > This is a release for Apache MRUnit, version 1.1.0. >> >> > >> >> > It fixes the following issues: >> >> > >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311292&version=12324262 >> >> > >> >> > *** Please download, test and vote by 6/3/2014. >> >> > >> >> > Note that we are voting upon the source (tag), binaries are provided >> >> > for convenience. >> >> > >> >> > Source and binary files: >> >> > http://people.apache.org/~brock/mrunit-1.1.0-candidate-1/ >> >> > >> >> > Maven staging repo: >> >> > >> >> >> https://repository.apache.org/content/repositories/orgapachemrunit-1001/ >> >> > >> >> > The tag to be voted upon: >> >> > >> >> >> https://git-wip-us.apache.org/repos/asf?p=mrunit.git;a=tag;h=3aba173b0bc811406e2aac31e8d8bdca11e66554 >> >> > >> >> >> https://git-wip-us.apache.org/repos/asf?p=mrunit.git;a=tag;h=d3e674f99a06355a05629c113e2edbf5664ec4bf >> >> > >> >> > MRUnit's KEYS file containing PGP keys we use to sign the release: >> >> > https://dist.apache.org/repos/dist/release/mrunit/KEYS >> >> >> > >> > >> > >
