> I think we should expose the MX/NN symbols, unless there's a downside to it.

The complication is how we go about doing the exporting. @yajiedesign maybe can 
add some more details, but a cursory search shows that you can use a cmake 
property WINDOWS_EXPORT_ALL_SYMBOLS to export everything and make it in line 
with how gcc works. But this will bloat the already bloated windows dlls. The 
other way to do it would be to go to the source files and add 
`__declspec(dllexport)` to only the symbol declarations we want to export. This 
is probably not feasible since it would mean we need to modify the 3rd party 
submodules as well. Plus, we'd need to do a bunch of work to figure out the set 
of symbols required manually. 

So really the only option is to use a cmake property WINDOWS_EXPORT_ALL_SYMBOLS 
and accept the bloat. Unless we drop windows and just say that this "external 
components" feature is linux only (C++ Custom operators can still be used on 
windows). 

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/18904#issuecomment-680282254

Reply via email to