+1
Very nicely written!.

We can link this wiki in the PR as a reference to guidelines(one line). I
think it is useful to remind people of the guidelines when they create a PR.

On Fri, Jul 7, 2017 at 2:14 PM, Chris Olivier <[email protected]> wrote:

> +1
>
> Although I am not a big fan of forcing people to fill out check-list forms
> :)
>
> On Fri, Jul 7, 2017 at 1:57 PM, sandeep krishnamurthy <
> [email protected]> wrote:
>
> > +1
> >
> > Is it possible to use this as a template or checklist that automatically
> > comes up for all new PRs, like how we generally use a template for new
> > issues and get required questions answered by users?
> >
> >
> > Regards,
> > Sandeep
> >
> > On Fri, Jul 7, 2017 at 1:41 PM, Madan Jampani <[email protected]>
> > wrote:
> >
> > > Hi Everyone,
> > >
> > > I put together a wiki page outlining the process and guidelines we
> could
> > > follow to better manage contributions to mxnet. This started out as a
> > > proposal to better manage the PR backlog. However it felt necessary to
> > > codify a set of guidelines or best practices new contributors could
> > follow
> > > to better prepare their contributions for a review and subsequent
> merge.
> > >
> > > I am opening it up to the community for feedback.
> > >
> > > https://cwiki.apache.org/confluence/display/MXNET/Development+Process
> > >
> > > Madan.
> > >
> >
> >
> >
> > --
> > Sandeep Krishnamurthy
> >
>

Reply via email to