rahul003 commented on issue #7236: change unnecessarily longer array
URL: https://github.com/apache/incubator-mxnet/pull/7236#issuecomment-318752603
 
 
   I initialized like this because variable length array declaration like 
```DType[n_channels]``` are not technically allowed by C++ standard. I read 
that g++ does allow it as an extension (if we don't use the flag 
```-pedantic```. I have verified that ```DType[n_channels]``` does work on 
g++4.8 and g++5 on Linux. I wasn't sure if we can rely on this flag not being 
used. 
   
   The alternative to the above would be dynamically create array using new.
   
   Should I just declare it as ```DTypes[n_channels]```. It does work with the 
default config flags and config.mk configs.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to