Thats an interesting suggestion. I understand the benefits, but this will complicate things if we want to do another quick release like the previous one (for eg. if there is a license issue because of which the release is cancelled).
Anirudh On Thu, May 17, 2018 at 9:23 PM, Naveen Swamy <[email protected]> wrote: > why don't we cherry-pick and push it to the branch as well ? next time a > release is cut from that branch we'll have everything working. > > On Thu, May 17, 2018 at 9:21 PM, Anirudh <[email protected]> wrote: > > > Correction : This fix went into master but not 1.2 release. > > > > On Thu, May 17, 2018 at 9:21 PM, Anirudh <[email protected]> wrote: > > > > > Hi Xinyu, > > > > > > Thank you! This fix didnt went into master but not 1.2 release. > > > > > > Anirudh > > > > > > On Thu, May 17, 2018 at 5:23 PM, Chen, Xinyu1 <[email protected]> > > > wrote: > > > > > >> Hi all, > > >> > > >> Regarding to the following knowing issues listed below RC3: > > >> > > >> > > >> * CMake build ignores the USE_MKLDNN flag and doesn't build with > > >> MKLDNN support even with -DUSE_MKLDNN=1. To workaround the issue > please > > >> see: #10801<https://github.com/apache/incubator-mxnet/issues/10801>. > > >> I think this problem has already been fixed in #10629< > > >> https://github.com/apache/incubator-mxnet/pull/10629> and we can use > > >> CMake to build MXNet with MKLDNN support on WIN32 platform now. > > >> Xinyu > > >> > > >> > > > > > >
