Hi all, We have one last PR before code freeze: https://github.com/apache/incubator-mxnet/pull/11298
Anirudh On Thu, Jun 14, 2018 at 11:46 AM, Anirudh <[email protected]> wrote: > Waiting on CI for the PRs: #11236, #11210, #11267 > > Other PRs have been merged. > > On Wed, Jun 13, 2018 at 10:50 PM, Anirudh <[email protected]> wrote: > >> Thanks Tao! Yes, this shouldn't be a blocker for 1.2.1. >> >> On Wed, Jun 13, 2018 at 10:46 PM, Lv, Tao A <[email protected]> wrote: >> >>> >>> Yes, #10311 is only in master branch, so I guess it won't impact 1.2.0 >>> branch and block the release of 1.2.1, right? >>> >>> A PR (#11273) is submitted to disable the test temporally and hopefully >>> it will be fixed soon. >>> >>> -tao >>> >>> -----Original Message----- >>> From: Marco de Abreu [mailto:[email protected]] >>> Sent: Thursday, June 14, 2018 1:21 PM >>> To: [email protected] >>> Subject: Re: Update on 1.2.1 release >>> >>> On windows tests a segfault is indicated by "If -764728474728". I have >>> also seen it happen on Ubuntu, there are probably some links in the issue >>> (on my phone right now). >>> >>> Anirudh <[email protected]> schrieb am Mi., 13. Juni 2018, 22:16: >>> >>> > By segfaulting test do you mean : test_gru_bidirectional. I don't see >>> > the segfault in the logs. Can you point me to the test. >>> > Also, this seems to be specific to the master and not in 1.2: >>> > https://github.com/apache/incubator-mxnet/pull/10311 >>> > >>> > Anirudh >>> > >>> > On Wed, Jun 13, 2018 at 10:00 PM, Marco de Abreu < >>> > [email protected]> wrote: >>> > >>> > > I can confirm that this segfaulting test has a big impact. >>> > > >>> > > On Wed, Jun 13, 2018 at 9:39 PM Aaron Markham >>> > > <[email protected] >>> > > >>> > > wrote: >>> > > >>> > > > I'd keep an eye on this one... Flaky test: test_gru_bidirectional >>> > #11219 >>> > > > >>> > > > https://github.com/apache/incubator-mxnet/issues/11219 >>> > > > >>> > > > Just reran several PR's CI runs that all had the same error! >>> > > > >>> > > > On Wed, Jun 13, 2018 at 5:42 PM, Anirudh <[email protected]> >>> > wrote: >>> > > > >>> > > > > Hi, >>> > > > > >>> > > > > PRs still in progress : #11127, #11236, #11210, #11054, #11216. >>> > > > > >>> > > > > We are currently facing two issues which are delaying the merge >>> > > > > of >>> > some >>> > > > of >>> > > > > these PRs: >>> > > > > 1. Flaky tests for scala API. A PR is already out to disable the >>> > test: >>> > > > > https://github.com/apache/incubator-mxnet/issues/11249 >>> > > > > 2. Builds breaking on windows: >>> > > > > https://github.com/apache/incubator-mxnet/issues/11265 >>> > > > > >>> > > > > Anirudh >>> > > > > >>> > > > > >>> > > > > On Tue, Jun 12, 2018 at 11:59 AM, Anirudh >>> > > > > <[email protected]> >>> > > wrote: >>> > > > > >>> > > > > > Hi all, >>> > > > > > >>> > > > > > Here are the PRs that are being tracked for 1.2.1 release: >>> > > > > > >>> > > > > > Related to the save_params backwards incompatible change: >>> > > > > > #11127 >>> > (In >>> > > > > > Progress), #11236 (In Progress), #11210 (In Progress) MKLDNN >>> > > > > > Fixes: #11212 (In Progress) Cross compilation for armv7 : >>> > > > > > #11054 (In Progress) Scala Inference Memory leak fix: #11216 >>> > > > > > (In Progress) Docs changes: #11211 (Merged) Inplace RELU >>> > > > > > Activation, Slice operator perf improvement: #11142 >>> > > > (Merged) >>> > > > > > Use cudnnv7 for depthwise conv #11233 (Merged) >>> > > > > > >>> > > > > > Please let me know if I have missed something. >>> > > > > > >>> > > > > > Anirudh >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > >>> >> >> >
