Thanks for the fast review on a Sunday! Waiting for tests to pass now. I'll merge it as soon as the PR is ready and will give an update here.
-Marco On Sun, Jul 1, 2018 at 1:04 PM Carin Meier <[email protected]> wrote: > Reviewed and approved. Thanks for putting it together :) > > On Sun, Jul 1, 2018 at 6:55 AM, Marco de Abreu < > [email protected]> wrote: > > > PR is available at https://github.com/apache/incubator-mxnet/pull/11512. > > So > > far, it's looking good. None the less, please review :) > > > > -Marco > > > > On Sun, Jul 1, 2018 at 12:46 PM Carin Meier <[email protected]> > wrote: > > > > > Yay on the merge! and Oh No! on the RAT. I'm up now too and taking a > look > > > too. > > > > > > On Sun, Jul 1, 2018 at 5:56 AM, Marco de Abreu < > > > [email protected]> wrote: > > > > > > > Congratulations! Unfortunately was the last CI run of that PR stale > and > > > did > > > > not include the latest updates to our pipeline. We just added the rat > > > > license check which apparently did not run on your PR send is now > > failing > > > > on master as well as blocking all pull request builds. I will try to > > add > > > > the licenses myself to unblock CI, but if you are currently around > > Carin, > > > > please let me know. > > > > > > > > http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/ > > > > incubator-mxnet/detail/master/1118/pipeline > > > > > > > > Best regards, > > > > Marco > > > > > > > > Pedro Larroy <[email protected]> schrieb am So., 1. Juli > > > 2018, > > > > 09:05: > > > > > > > > > Congrats on the PR being merged. > > > > > > > > > > On Fri, Jun 29, 2018 at 3:02 PM Carin Meier <[email protected]> > > > > wrote: > > > > > > > > > > > Thanks for reviewing for the PR. I answered the questions there > and > > > am > > > > > > happy to discuss it further if you would like. > > > > > > > > > > > > - Carin > > > > > > > > > > > > > > > > > > On Fri, Jun 29, 2018 at 3:02 AM, YiZhi Liu <[email protected]> > > > > wrote: > > > > > > > > > > > > > Thanks Carin for the great contribution. I just left several > > > > questions > > > > > > > in the PR, would you mind to take a look? Sorry for the late > > > review. > > > > > > > On Thu, Jun 28, 2018 at 12:14 PM Hagay Lupesko < > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > > > > Thanks for your contribution Carin! > > > > > > > > Unfortunately i can't do a proper review for Clojure, but > it's > > > > great > > > > > to > > > > > > > see > > > > > > > > the contribution and see how it develops and grows... > > > > > > > > > > > > > > > > On Thu, Jun 28, 2018 at 11:11 AM Carin Meier < > > > [email protected] > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Thanks everyone for your feedback and efforts with the > > Clojure > > > > > > package > > > > > > > PR. > > > > > > > > > > > > > > > > > > I'm delighted to join the MXNet community and work with you > > all > > > > and > > > > > > am > > > > > > > > > excited to invite the Clojure community to grow with it :) > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Carin > > > > > > > > > > > > > > > > > > On Thu, Jun 28, 2018 at 1:38 PM, Pedro Larroy < > > > > > > > > > [email protected]> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Yes, great work Carin! I even saw your book on Clojure > > > > > autographed. > > > > > > > > > > > > > > > > > > > > Pedro. > > > > > > > > > > > > > > > > > > > > On Wed, Jun 27, 2018 at 7:24 PM Naveen Swamy < > > > > [email protected] > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi All, > > > > > > > > > > > > > > > > > > > > > > Carin (https://github.com/gigasquid) has done a worked > > on > > > a > > > > > > > Clojure > > > > > > > > > > MXNet > > > > > > > > > > > package for the Clojure community, Thank you Carin. > > > > > > > > > > > > > > > > > > > > > > I would like to merge this PR#11205 for the upcoming > > > release > > > > > > 1.3. > > > > > > > I am > > > > > > > > > > not > > > > > > > > > > > a Clojure developer and plan to just do a preliminary > > > review > > > > > for > > > > > > > > > > licenses, > > > > > > > > > > > tests, etc., and merge the code. Myself and Pedro > called > > on > > > > > help > > > > > > > from > > > > > > > > > the > > > > > > > > > > > Clojure community in our day job at Amazon and also > > Carin's > > > > > also > > > > > > > got > > > > > > > > > some > > > > > > > > > > > peers from the Clojure community to help with the > review. > > > > > > > > > > > > > > > > > > > > > > If there is a committer who would like to do a complete > > > > review, > > > > > > > I'll be > > > > > > > > > > > happy to step back and let you do it otherwise this PR > is > > > > going > > > > > > in > > > > > > > by > > > > > > > > > the > > > > > > > > > > > end of week to make it ready for 1.3. > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-mxnet/pull/11205 > > > > > > > > > > > > > > > > > > > > > > Let me know > > > > > > > > > > > > > > > > > > > > > > Thanks, Naveen > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Yizhi Liu > > > > > > > DMLC member > > > > > > > Amazon Web Services > > > > > > > Vancouver, Canada > > > > > > > > > > > > > > > > > > > > > > > > > > > >
