Here's a PR that addresses this, and more, for review: https://github.com/apache/incubator-mxnet/pull/12388
On Tue, Aug 28, 2018, 13:21 Lin Yuan <[email protected]> wrote: > When a user chooses to build from source, it is reasonable to infer that > they want to run the make process and install the python package > subsequently. The current automated build script is confusing in that I > really have no idea what I should do if I want to change some of the source > code in MXNet. Furthermore, building from source on MacOS should have the > same/similar process as in building from source on Linux since they have > the same shell environment. Having two different build instructions on > MacOS just adds additional confusion. > > > > On Tue, Aug 28, 2018 at 10:44 AM Bhavin Thaker <[email protected]> > wrote: > > > The automated build script on macOS was written with the intention to > have > > an automated, easy and quick way to build and install MXNet by any user, > > new-bie or advanced. The build script aims to provide repeatability and > an > > easy way to test the build instructions. > > > > Without the script, the build instructions had many combinations of > > possibilities which would break for various users and there was no easy > way > > to test all the combinations. > > > > I propose that we have both well-written build instructions with > > corresponding automated build script to ensure that the build > instructions > > are well-tested. > > > > Please remember that there can be multiple use-cases and user preferences > > to build MXNet. > > > > Bhavin Thaker. > > > > On Tue, Aug 28, 2018 at 10:29 AM Afrooze, Sina <[email protected]> > wrote: > > > > > +1 on fully automated scripts being more confusing than helpful. It's > > > difficult to debug any issues when the entire instruction is to run a > > > single script. - Sina > > > > > > > > > > > > On 8/28/18, 9:46 AM, "Lin Yuan" <[email protected]> wrote: > > > > > > Aaron, > > > > > > I agree the installation page is very confusing to me. When I first > > > tried > > > to build MXNet from source on MacOS, I was totally confused about > the > > > instruction. Why was it vastly different from building from source > on > > > Linux > > > given these two OS have similar shell commands. I feel the > automatic > > > scripts on MacOS platform is rather confusing than simplifying. > > > > > > Lin > > > > > > On Mon, Aug 27, 2018 at 9:21 PM Steffen Rochel < > > > [email protected]> > > > wrote: > > > > > > > Aaron - we should keep instructions how to build from source. > > > Updating and > > > > re-organizing makes sense to me. > > > > Steffen > > > > > > > > On Mon, Aug 27, 2018 at 4:54 PM Aaron Markham < > > > [email protected]> > > > > wrote: > > > > > > > > > Hello, > > > > > I was looking into the C++ instructions and came across this > > > seemingly > > > > > pretty old page: > > > > > https://mxnet.incubator.apache.org/install/build_from_source > > > > > > > > > > I think it has several inaccuracies as different/updated > > > installation > > > > info > > > > > has been added to different pages. > > > > > > > > > > Should it be deleted? > > > > > > > > > > Or should a specific build from source page be maintained > > > (moving/copying > > > > > info from the other more recently updated pages)? > > > > > > > > > > I'm really thinking that it would be easier to maintain if each > > OS > > > had > > > > its > > > > > own page, Python/pip info had its own page, then bindings had > > > their own > > > > > pages. > > > > > > > > > > Other suggestions? > > > > > > > > > > Cheers, > > > > > Aaron > > > > > > > > > > > > > > > > > > > > > > > >
