+1 Great idea. Adding a name to the contributor list is a good idea. Also, I've found that thanking the person for the review on the PR is another way to express gratitude for their time and effort.
On Fri, Oct 19, 2018 at 2:51 PM Tianqi Chen <tqc...@apache.org> wrote: > Dear MXNet Community: > > There is a great discussion going on in terms of lowering the barrier of > entries and encourage more contribution to the project. One of the general > goals is to encourage a broader pool of contributions. I want to make the > following proposal: > > Besides Committers and PMC, let us also recognize Reviewers in the > community. This is a "pseudo role" as there is no such official role in > Apache. But I want to explore the possibility of recognizing active > reviewers for example, by adding a list of names in the contributor list. > In general, I find it is really helpful to have more code reviews. > Recognizing good reviewers early enables us to find committer candidates, > and encourage them to contribute and understand what is the bar of code > quality that is required to merge the code. > > This can provide the community with more evidence when recruiting new > committers. After all the write access of committership is about to the > code and understand the consequence of the responsibility -- which is > usually can be found in high-quality review history. > > Please let me know what you think. > > Tianqi >
