I would think that if we are using nnvm from tvm we should not have duplicated code in our repository. I think we either use the subrepository as a 3rdparty or assimilate the code in the codebase as what is planned with mshadow. But I guess TVM is making heavy use of nnvm, and this case might make sense to reause across projects. @Tianqi?
On Thu, Apr 11, 2019 at 10:16 PM Junru Shao <[email protected]> wrote: > > We should remove 3rdparty/tvm/nnvm/gradient.cc.o imo > > On Thu, Apr 11, 2019 at 6:44 PM Pedro Larroy <[email protected]> > wrote: > > > Hi > > > > I found that src/nnvm and 3rdparty/tvm/nnvm/src/pass/ has duplicated > > code that we are linking in: > > > > ./CMakeFiles/mxnet_static.dir/3rdparty/tvm/nnvm/src/pass/gradient.cc.o > > ./CMakeFiles/mxnet_static.dir/src/nnvm/gradient.cc.o > > > > This can potentially cause problems when linking. The symbol that will > > be used is left as an exercise to the readers. > > > > Is this intentional? Should we address this? > > > > Pedro. > >
