Might be helpful if you wrote a unit test for this and other behaviors that DGL depends upon to reduce the likelihood that it happens again. Just a suggestion. That would show good ownership, imho.
On Tue, May 21, 2019 at 6:11 PM Chris Olivier <[email protected]> wrote: > Thanks for clarifying, Da. > > On Tue, May 21, 2019 at 5:44 PM Zheng, Da <[email protected]> > wrote: > >> DGL is a framework of deep learning on graphs. https://www.dgl.ai/ >> >> It's not that MXNet is responsible to be compatible with DGL. The crashes >> are caused by bugs in MXNet. >> >> Best, >> Da >> >> On 5/21/19, 5:39 PM, "Chris Olivier" <[email protected]> wrote: >> >> Curious what is DGL and what is Apache/MXNet’s responsibility to it to >> maintain compatibility rather than the other way around? >> >> On Tue, May 21, 2019 at 3:39 PM Zheng, Da <[email protected]> >> wrote: >> >> > Hello all, >> > >> > I recently find that DGL don’t run with the recent MXNet. DGL >> crashes with >> > memory errors. >> > Yesterday we have identified a bug in DLPack and Junru has >> implemented a >> > fix: https://github.com/apache/incubator-mxnet/pull/15016 >> > However, there are some other bugs that causes DGL to crash with a >> memory >> > error. I’m still searching among the PRs to identify the one that >> causes >> > the issue. I think we should make sure that MXNet 1.5 release works >> with >> > DGL correctly. >> > >> > Best, >> > Da >> > >> >> >>
