Hi Lai, I have opened an issue: https://github.com/apache/incubator-mxnet/issues/15297 I came to know about this issue only today and I have not been monitoring sockeye. I jumped onto this issue to make sure it wasn't caused by the dlpack changes. Also, I don't think sockeye CI checks against master, it is using 1.4.1.
Anirudh On Thu, Jun 20, 2019 at 6:17 PM Lai Wei <roywei...@gmail.com> wrote: > Hi, > > Could you share which test failed and what’s the crash? How to reproduce > it? > > I was able to install sockeye and run all tests passed. Using > python setup.py test > > I have tested both nightly pip package and 1.5.0.rc1 > > It would be great to create an issue with reproducible steps and move the > discussion there. > > Also I see sockeye nightly build[1] has been failing for some time, if it’s > due to MXNet change, please raise this early so we can track and solve it > in time rather than block the release during vote time. > > [1] https://travis-ci.org/awslabs/sockeye > > > On Fri, Jun 21, 2019 at 7:01 AM Anirudh Subramanian <anirudh2...@gmail.com > > > wrote: > > > I was able to reproduce a crash with the commit > > 09202f7f261954383aa387144524d38f83f18d06 but not with the commit > > a862270beb2d796c1ba311183f7f4a766a18ad6c. > > > > Anirudh > > > > On Thu, Jun 20, 2019 at 3:53 PM Lai Wei <roywei...@gmail.com> wrote: > > > > > Hi Przemyslaw, > > > > > > Is there an issue with more details to track the problem? > > > > > > > > > On Fri, Jun 21, 2019 at 6:04 AM Przemysław Trędak <ptre...@apache.org> > > > wrote: > > > > > > > -1 > > > > > > > > There is a crash in sockeye unit test (python setup.py test) observed > > > > starting with nightly 1.5 build from 6/13 and still occuring in > > 1.5rc1. I > > > > don't yet have the exact commit that is responsible for it, but it is > > > > either a862270beb2d796c1ba311183f7f4a766a18ad6c (dlpack related) or > > > > 09202f7f261954383aa387144524d38f83f18d06 (cached op optimization). > > > > > > > > On 2019/06/20 06:36:22, Lai Wei <roywei...@gmail.com> wrote: > > > > > Dear MXNet community, > > > > > > > > > > This is the 3-day vote to release Apache MXNet (incubating) version > > > > 1.5.0. > > > > > Voting on dev@ will start June 19, 23:59:59(PST) and close on > June > > > 22, > > > > > 23:59:59. > > > > > > > > > > 1) Link to release notes: > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes > > > > > > > > > > > > > > > 2) Link to release candidate: > > > > > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc1 > > > > > > > > > > > > > > > 3) Link to source and signatures on apache dist server: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc1/ > > > > > > > > > > > > > > > Please remember to TEST first before voting accordingly: > > > > > > > > > > +1 = approve > > > > > +0 = no opinion > > > > > -1 = disapprove (provide reason) > > > > > -- > > > > > Best Regards > > > > > > > > > > Lai > > > > > > > > > > > > -- > > > Best Regards > > > > > > Lai > > > > > > -- > Best Regards > > Lai >
