Hi Oliver,
MShadow was a 3rd party component, but since its deprecation it was donated to
the MXNet community and the source code is now only in the MXNet github repo
(not a true 3rd party component anymore). Feel free to open a PR with a fix.
Thanks!
Sam
On 5/29/20, 9:46 AM, "Oliver Kowalke" <oliver.kowa...@gmail.com> wrote:
CAUTION: This email originated from outside of the organization. Do not
click links or open attachments unless you can confirm the sender and know the
content is safe.
Hi,
code in mshadow/mshadow/tensor.h might cause UB.
Member function Shape<int>::operator[](int idx) does not check for array
boundaries.
GCC causes a warning (error with -Werror).
How to deal with it? Is it accepted to patch 3rdpart components?
A solution is to throw an exception (costs runtime performance), another is
to disable the warning for this specific code (then the user must check it).
Oliver
