The attributes that I'm talking about is the _ComponentAttributesMap which I thought was returned with a call to UIComponent.getAttributes();
On Wed, 12 Jan 2005 19:32:46 +0100, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > Heath, > > just a (perhaps silly question)... > > Aren't in the map, deliverd by getAttributes(), > only the attributes of a UIComponent? > Which I *attach* with the tag <f:attribute value="foo" name="bar"/> ? > > And not the properties of a UIComponent? > Which are *accessible* via attribute of JSF-Tag? > > Or am I now wrong? > > Or did I missunderstood you? > > Thanks, > Matthias > > > -----Original Message----- > > From: Heath Borders [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, January 12, 2005 5:16 PM > > To: Matthias Wessendorf > > Subject: Re: FW: [Fwd: UIComponent.getAttributes().get() and > > ValueBinding] > > > > > > In almost all of our UIComponent getters we have the following code: > > > > public String getProperty() > > { > > if (property != null) > > { > > return property; > > } > > > > // ValueBinding checking code > > ValueBinding vb = getValueBinding("property"); > > return vb != null ? vb.getValue(getFacesContext()) : null; > > } > > > > And in the _ComponentAttributesMap, we have the the following code: > > > > Object value = getComponentProperty(propertyDescriptor); > > if (value != null) > > { > > return value; > > } > > > > // ValueBinding checking code > > ValueBinding vb = _component.getValueBinding((String) key); > > return vb != null ? > > vb.getValue(FacesContext.getCurrentInstance()) : null; > > > > > > So, if a ValueBinding doesn't exist (or one does exist, but > > it is null), we will execute the ValueBinding checking code twice. > > > > I don't have a solution to the problem, but I think the > > specification saying that the attributesMap has to perform > > this way is going to require this rendundant checking. It > > would be better to say that any property that is bindable > > should have the checking code inside, and then have a helper > > method on the UIComponentBase to decrease boilerplate code. > > > > On Wed, 12 Jan 2005 17:08:58 +0100, Matthias Wessendorf > > <[EMAIL PROTECTED]> wrote: > > > mmm, > > > > > > in which cases? > > > > > > > -----Original Message----- > > > > From: Heath Borders [mailto:[EMAIL PROTECTED] > > > > Sent: Wednesday, January 12, 2005 5:04 PM > > > > To: Matthias Wessendorf > > > > Subject: Re: FW: [Fwd: UIComponent.getAttributes().get() and > > > > ValueBinding] > > > > > > > > > > > > Isn't it possible that this fix will cause redundant > > checks to the > > > > ValueBindings? > > > > > > > > > > > > On Fri, 7 Jan 2005 15:28:34 +0100, Matthias Wessendorf > > > > <[EMAIL PROTECTED]> wrote: > > > > > :-) > > > > > > > > > > now i have something todo at weekend :-))) > > > > > > > > > > thanks! > > > > > > > > > > I hope I could include also Kalle's component. > > > > > > > > > > but sounds good... my girlfriend is away ... > > > > > so there is no "showstopper" :-D > > > > > > > > > > > -----Original Message----- > > > > > > From: Heath Borders [mailto:[EMAIL PROTECTED] > > > > > > Sent: Friday, January 07, 2005 3:26 PM > > > > > > To: Matthias Wessendorf > > > > > > Subject: Re: FW: [Fwd: UIComponent.getAttributes().get() and > > > > > > ValueBinding] > > > > > > > > > > > > > > > > > > Yeah, its no problem. I'm in no hurry. > > > > > > > > > > > > I posted the feature as MYFACES-74. > > > > > > > > > > > > > > > > > > On Fri, 7 Jan 2005 15:14:29 +0100, Matthias Wessendorf > > > > > > <[EMAIL PROTECTED]> wrote: > > > > > > > It is a pdf the needs to be sended to > > > > > > > facsimile of ASF. > > > > > > > > > > > > > > But, I suggest you to wait for MyFaces > > > > > > > is toplevel :-) > > > > > > > > > > > > > > After we could concentrate on things like > > > > > > > adding competent guys like you. > > > > > > > > > > > > > > HTH, > > > > > > > Matthias > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Heath Borders [mailto:[EMAIL PROTECTED] > > > > > > > > Sent: Friday, January 07, 2005 3:12 PM > > > > > > > > To: Matthias Wessendorf > > > > > > > > Subject: Re: FW: [Fwd: > > UIComponent.getAttributes().get() and > > > > > > > > ValueBinding] > > > > > > > > > > > > > > > > > > > > > > > > Sure, I can give you an address if you need to mail it to > > > > > > me or is > > > > > > > > it electronic? > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 7 Jan 2005 15:08:59 +0100, Matthias Wessendorf > > > > > > > > <[EMAIL PROTECTED]> wrote: > > > > > > > > > > Do you want me to actually make this change, or do you > > > > > > > > just want to > > > > > > > > > > know my opinion? > > > > > > > > > > > > > > > > > > Well, if you like to change, feel free! > > > > > > > > > you could submit a patch. I will take care. > > > > > > > > > > > > > > > > > > You are deep in the things now. I am deep in releasing, > > > > > > > > > changing website and writing docu for my thesis :-) > > > > > > > > > > > > > > > > > > BTW. for beeing a comitter you must sign the > > CLA from ASF. > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Matthias > > > > > > > > > > > > > > > > > > > Personally, I'd rather see this happen in the > > attributes > > > > > > > > map so that > > > > > > > > > > our UIComponent code would be MUCH cleaner. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 7 Jan 2005 13:24:30 +0100, Matthias > > Wessendorf > > > > > > > > > > <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > Hi Heath, > > > > > > > > > > > > > > > > > > > > > > this is such a message from the PMC. > > > > > > > > > > > Ed Burns mailed something to Manfred > > > > > > > > > > > > > > > > > > > > > > on the topic, which is *heavily* disscussed by you > > > > > > > > (thanks again) > > > > > > > > > > > > > > > > > > > > > > so perhaps you have some ideas on that? > > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > > > Matthias > > > > > > > > > > > > > > > > > > > > > > -------- Original-Nachricht -------- > > > > > > > > > > > Betreff: UIComponent.getAttributes().get() and > > > > > > > > > > > ValueBinding > > > > > > > > > > > Datum: Thu, 06 Jan 2005 12:42:28 -0500 > > > > > > > > > > > Von: Ed Burns <[EMAIL PROTECTED]> > > > > > > > > > > > Antwort an: Ed Burns <[EMAIL PROTECTED]> > > > > > > > > > > > An: Manfred Geiler <[EMAIL PROTECTED]> > > > > > > > > > > > > > > > > > > > > > > Hello Manfred, > > > > > > > > > > > > > > > > > > > > > > This thread [1] in the MyFaces user group was > > > > brought to > > > > > > > > > > > my > > > > > > > > > > attention > > > > > > > > > > > by Craig McClanahan. It points to a subtle but > > > > > > important spec > > > > > > > > > > > omission. > > > > > > > > > > > > > > > > > > > > > > The Sun RI for > > > > UIComponent.getAttributes().get() does the > > > > > > > > > > > following: > > > > > > > > > > > > > > > > > > > > > > 1 If there is a javaBeans getter for the > > > > property, return > > > > > > > > > > the result of > > > > > > > > > > > calling it. > > > > > > > > > > > > > > > > > > > > > > 2 If there is an actual attribute for that name, > > > > > > > > > > > return it. > > > > > > > > > > > > > > > > > > > > > > 3 If there is a valueBinding for that name, > > return the > > > > > > > > > > result of doing a > > > > > > > > > > > get on it. > > > > > > > > > > > > > > > > > > > > > > The spec doesn't mention step 3, but it is > > important. > > > > > > > > I plan to > > > > > > > > > > > produce an errata to the 1.1 spec well > > before 1.2 goes > > > > > > > > > > > out, > > > > > > > > > > but in the > > > > > > > > > > > meantime, can you please fix myfaces to do step 3? > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > > > > > Ed > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > http://nagoya.apache.org/eyebrowse/ReadMsg?listId=267&msgNo=94 > > > > > > > > > > > > > > > 8 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > -Heath Borders-Wing > > > > > > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > -Heath Borders-Wing > > > > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > -Heath Borders-Wing > > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > -- > > > > -Heath Borders-Wing > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > -- > > -Heath Borders-Wing > > [EMAIL PROTECTED] > > > > -- -Heath Borders-Wing [EMAIL PROTECTED]
