Well, there was a customization made by Thomas in the JS file. Tomorrow I will create the patch to include again the needed lines in the function cmItemMouseUp, needed to work with the component HtmlCommandJsCookMenu. Unfortunately, this means that the menu will use again it's own dummy form and cannot be included in other forms. Then MYFACES-24 cannot be solved until we find a solution for the dummy form issue... more to think about ;)
Bruno 2005/6/2, Sylvain Vieujot <[EMAIL PROTECTED]>: > I understood that the JSCook menu was [icon, title, url, description]. > So maybe the older version was customized to use the id. > But it looks normal that it doesn't work using the additional id parameter. > > A diff on my last commit should give you the clue. > Thank you for taking time to looks into this. I'm just very busy right now. > > Sylvain. > > > On Wed, 2005-06-01 at 23:57 +0200, Bruno Aranda wrote: > No problem, tomorrow I will try to fix it. It is positive to improve > support so better if we can have the 1.3.1. At first glance it has > something to do with the url's, but I am not an expert with the menu. > For example, this is what the renderer outputs for a NavigationItem: > > ['<img src="images/myfaces.gif"/>', 'Selectboxes', > 'id0_menu:go_selectbox', '#', null], > > Then the browser tries to follow the 'id0_menu:go_selectbox' as url, > and does not submit the form. I guess it is that in the JS file there > is a window.open() while in the version before there was a > form...submit()? > > Bruno > > > > 2005/6/1, Sylvain Vieujot <[EMAIL PROTECTED]>: > > It must be my fault then. > > I updated the JS code to the last version (1.3.1 - it was 1.2.??). > > The last version has many enhancements (Opera & Safari support, ...). > > My test worked, bu maybe I was a little quick on that. > > In addition, a diff on the code showed only sensible changed. > > > > If you can fix it for the last code, it would be better I think. > > Otherwise, I can revert it to version 1.2.x. > > > > Sorry for that. > > > > Sylvain. > > > > > > On Wed, 2005-06-01 at 12:54 -0700, Jon Travis wrote: > > Something very recent seems to have broken JSCookMenu. It was > > working fine for me from an update of a few days ago, but with > > this morning's update, it broke. > > > > -- Jon > > > > > > On Jun 1, 2005, at 12:01 PM, Bruno Aranda wrote: > > > > > Does the jscookmenu work for you? I am resolving issue MYFACES-27 > > > but doing some preliminary tests with the myfaces-examples I've > > > seen that the jscookmenu from the examples does not work (with or > > > without my patch). The same happens for the jscookmenu in the > > > myfaces-samples-examples so I guess that a recent change broke the > > > menu or, as usual, I am missing something ;-) > > > About the MYFACES-27, when the issue was created the menu could not > > > work inside <h:form> tags, so the immediate attribute was > > > unnecessary, but now is a possibility and this is why I am creating > > > a patch. > > > > > > Regards, > > > > > > Bruno > > > > > > > > > >
