Bogus warning logged for servlets with "init-param"
---------------------------------------------------

         Key: MYFACES-283
         URL: http://issues.apache.org/jira/browse/MYFACES-283
     Project: MyFaces
        Type: Bug
    Versions: Nightly Build    
    Reporter: Ray Davis
    Priority: Trivial


In 1.0.9 and the trunk, when a servlet configuration includes an "init-param", 
WebXmlParser (src/share/org/apache/myfaces/webapp/webxml/WebXmlParser.java) 
logs a warning:

WARN: Ignored element 'init-param' as child of 'servlet'.

This clutters up the log with distractions. Here's the responsible code:

    private void readServlet(Element servletElem)
    {
...
                else if (n.getNodeName().equals("description") || 
n.getNodeName().equals("load-on-startup"))
                {
                    //ignore
                }
                else
                {
                    if (log.isWarnEnabled()) log.warn("Ignored element '" + 
n.getNodeName() + "' as child of '" + servletElem.getNodeName() + "'.");
                }

Since init-param is a perfectly fine element, it should be ignored just like 
"load-on-startup".

Also, any element that MyFaces doesn't recognize should arguably be logged at 
an "info" level, like nodes that it doesn't recognize.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to