Hi Stan,
Thank you for your reply.
Stan Silvert wrote:
In that case, please put your request into Jira. I'd like to understand
a little more about it. Then we can all vote on the feature.
http://myfaces.apache.org/issue.html
Okay, I'll create the patch for MyFaces and then put it
into Jira.
One part that concerns me is:
For other portals, if it has
a mechanism like J2's HeaderResource feature, I will be
able to implement this enhancement.
Do you mean that a plug-in will be required for each portal?
Yes.
My understanding is, MyFaces puts some tags into <head> by
ExtentionsFilter. But, in portlet, I think it's a proper
way that MyFaces's portlet handles the tag without ExtentionsFilter
and communicates to the portal to put them into <head>.
In order to handle the tags in the portal, my suggestion has
plug-in for portal. If portal does not have the mechanism
like J2's HeaderResource, the portal can skip this feature.
I'd still rather see it be done as an extension to
MyFacesGenericPortlet. That class is already too bloated as it is. If
you have refactoring suggestions please let me know.
Okay, thanks.
Also, this line won't work:
HttpServletResponseWrapper responseWrapper = new
HttpServletResponseWrapper((HttpServletResponse) response);
RenderResponse can not be cast to an HttpServletResponse on all portal
implementations.
In 1.0.9, AddResouce class bothered me.. But, in the latest
code, since private is changed to protected, I may be able to
avoid this problem. Anyway, I'll check it.
Regards,
shinsuke
Stan Silvert
JBoss, Inc.
[EMAIL PROTECTED]
callto://stansilvert
-----Original Message-----
From: Shinsuke SUGAYA [mailto:[EMAIL PROTECTED]
Sent: Tuesday, August 16, 2005 6:37 PM
To: MyFaces Development
Subject: Re: MyFacesGenericPortlet
Stan Silvert wrote:
I assume J2 == JetSpeed 2?
Oops, sorry, I had abbreviated it..
Yes. J2 is Jetspeed2.
My first reaction is that this is something that belongs in the J2
project and not MyFaces. Can't you just extend
MyFacesGenericPortlet
and check it into J2?
The enhancement I suggest is independent from Jetspeed2.
So, I proposed it to Portals Bridges and MyFaces. Actually,
Portals Bridges is an independent project for portals, not
Jetspeed2. Therefore, I think it's proper to put the
enhancement to MyFaces(or Portals Bridges).
Is there anything here that is generally useful outside of J2?
Yes.
My suggestion does not depend on Jetspeed2.
So, I hope it work on other portals :)
If you can merge it, I'll create the patch for the latest code.
Regards,
shinsuke
Stan Silvert
JBoss, Inc.
[EMAIL PROTECTED]
callto://stansilvert
-----Original Message-----
From: Shinsuke SUGAYA [mailto:[EMAIL PROTECTED]
Sent: Monday, August 15, 2005 6:35 PM
To: [email protected]
Subject: MyFacesGenericPortlet
Hi developers,
I'm developer in Apache Portals.
Last week, I proposed the enhancement for MyFacesGenericPortlet to
Portals Bridges as MyFaces Bridges, and got a feedback(it's to
contact
to MyFaces team first). So, I would like to propose the enhancement
to MyFaces.
The enhancements I suggests for MyFacesGenericPortlet are:
- Supports components which use <script> and <link> tags
in <head> tag without ExtensionsFilter in the portal's
web.xml. J2 has HeaderResource feature to control tags
in <head>. Using the feature, the component, such as
inputHtml, works on J2. For other portals, if it has
a mechanism like J2's HeaderResource feature, I will be
able to implement this enhancement.
- Supports <x:fileUpload/> component.
- some minor modification.
I have already created it(based on 1.0.9) in SourceForge.jp,
and put the source code to:
http://cvs.sourceforge.jp/cgi-
bin/viewcvs.cgi/jetplume/jetplume/bridges/myfaces/
If MyFaces team can merge the enhancement, I would like
to create the patch based on the latest code. So, could you
merge it?
Any comments/suggestions are highly appreciated.
Regards,
shinsuke
__________________________________
Save the earth
http://pr.mail.yahoo.co.jp/ondanka/
__________________________________
Save the earth
http://pr.mail.yahoo.co.jp/ondanka/
__________________________________
Save the earth
http://pr.mail.yahoo.co.jp/ondanka/
