HtmlSwapImageTag should extend 
org.apache.myfaces.taglib.html.ext.HtmlGraphicImageTag
-------------------------------------------------------------------------------------

         Key: MYFACES-439
         URL: http://issues.apache.org/jira/browse/MYFACES-439
     Project: MyFaces
        Type: Sub-task
  Components: General  
    Versions: Nightly Build    
 Environment: Weblogic 8.1 SP3
    Reporter: Jeremy Grelle
    Priority: Blocker


Moving the non-JSF specified HTML 4.0 <img> attributes out of 
HtmlGraphicImageTagBase and into the extension HtmlGraphicImageTag (as was 
appropriate) caused MyFaces to break on Weblogic 8.1 because Weblogic validates 
the .tld and checks that there are appropriate setters in the *Tag class for 
each specified <attribute>.  Since HtmlSwapImageTag was extending 
HtmlGraphicImageTagBase, it no longer has the appropriate fields.  

Upon investigation it seems that someone added the border attribute back to 
HtmlGraphicImageTagBase after MYFACES-363 was closed, presumably because it was 
breaking the SwapImage example page that makes use of the border attribute.

It seems to me that the better solution is to have HtmlSwapImageTag extend 
org.apache.myfaces.taglib.html.ext.HtmlGraphicImageTag, so as to retain the 
ability to include the HTML 4.0 <img> attributes while not breaking compliance 
of <h:graphicImage> with the JSF 1.1 spec.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to