[ http://issues.apache.org/jira/browse/MYFACES-453?page=all ]

Martin Marinschek updated MYFACES-453:
--------------------------------------

    Attachment:     (was: ignore.txt)

> Tomahawk's use of HttpServletRequest breaks JSF Portlets
> --------------------------------------------------------
>
>          Key: MYFACES-453
>          URL: http://issues.apache.org/jira/browse/MYFACES-453
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.0.9 beta
>     Reporter: Stan Silvert
>     Assignee: Stan Silvert

>
> I have a report of a user who wanted to use JSCookMenu in a portlet.  This 
> results in a ClassCastException because 
> org.apache.myfaces.component.html.util.AddResource assumes that the 
> underlying request object will be an HttpServletRequest.
> I will fix this for AddResource, but I suspect that there are other offending 
> classes in Tomahawk.  
> For future reference, you should always use methods from  ExternalContext 
> instead of doing (HttpServletRequest)ExternalContext.getRequest().
> If you MUST use features of HttpServletRequest that ExternalContext doesn't 
> offer then you should use the PortletUtil to make sure that you don't break 
> portlets.  To tell if you are running in a portlet environment, you can say:
> org.apache.myfaces.portlet.PortletUtil.isPortletRequest(FacesContext 
> facesContext)
> Note: calling PortletUtil does not put any dependency on the Portlet API.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to