Sorry I haven't had a chance to look at it in detail. I've been really busy with my day job. I will try to look at it soon. Perhaps Mathias can also take a look?
sean On 9/9/05, Jon Travis <[EMAIL PROTECTED]> wrote: > No comments on this? The bugs are fairly serious. > Or should I just expect the comments to be "You found > it, now fix it!" ;-) > > -- Jon > > > > On Sep 6, 2005, at 5:40 PM, Jon Travis wrote: > > > I've been evaluating recent changes to Tree2 to see if they > > work out in a dynamic environment (when the contents of > > the tree are changing). > > > > Things don't appear to work yet, but they are better than > > they used to be. I've attached a couple patches which > > should help people locate the bugs. They change the tree2 > > example in the 'simple' examples to allow a user to delete > > any node. > > > > The tomahawk patch makes a change which I think is worthwhile. > > IMO, exposing the children list directly is a bad idea (though > > something that JSF does.) It's nicer to have explicit calls > > for adding/removing children, that way the parent has the > > option to do some cleanup if they like. > > > > Anyway, after applying the patches, here are some bugs that > > I've seen: > > > > Bug 1: > > - Navigate to localhost:8080/simple/tree2.jsf > > - Open (client side) Inbox/Frank Foo/Requires Bar Processing > > - Click delete next to GO50003 > > - Click delete next to FO50002 > > ** You'll see the error about 'duplicate IDs' here > > > > Bug 2: > > - Navigate to localhost:8080/simple/tree2.jsf > > - Open (server side) Inbox/Frank Foo/Requires Bar Processing > > - Click delete next to GO50003 > > ** Notice that icons and text disappear from the rest of the tree > > > > -- Jon > > > > > > <examples.diff> > > <tomahawk.diff> > > > > >
