+1 for rowOnClickAction
---------------------------------------------- Neal Haggard Senior Systems Developer Knowledge Management Center SAS Instititute -----Original Message----- From: Mathias Broekelmann (JIRA) [mailto:[EMAIL PROTECTED] Sent: Tuesday, September 13, 2005 11:26 AM To: [email protected] Subject: [jira] Closed: (MYFACES-558) Implementation of rowOnClick attribute for t:dataTable breaks underlying links in columns [ http://issues.apache.org/jira/browse/MYFACES-558?page=all ] Mathias Broekelmann closed MYFACES-558: --------------------------------------- Resolution: Invalid I don´t see why we should change this. IMO rowOnClick is exactly meant to work as <tr onClick="...">. If you need <td onClick="..."> use t:column for that. The only thing I see is to introduce something like rowOnClickAction and rowOnClickActionListener which let the user bind an action to the row event onClick. > Implementation of rowOnClick attribute for t:dataTable breaks > underlying links in columns > ---------------------------------------------------------------------- > ------------------- > > Key: MYFACES-558 > URL: http://issues.apache.org/jira/browse/MYFACES-558 > Project: MyFaces > Type: Bug > Components: Tomahawk > Versions: 1.0.10m10 > Reporter: Erik-Berndt Scheper > > The current implementation of rowOnClick in t:dataTable generates the > following template html: > <tr onclick="....."> > <td></td> > <td></td> > </tr> > This sounds a logical implementation, but it has one severe drawback: > In Internet Explorer (yuk) and Firefox this implies that links in the columns > (such as a command link) are no longer executed, because the <tr> onclick > handler gets precedence. > I suggest to change the implementation to <tr> > <td onclick="....."></td> > <td onclick="....."></td> > </tr> > However, care must be taken that the onclick handler on the <td> > attribute is NOT generated if the column contains an ActionSource. > Otherwise it is still impossible to click on the underlying links :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
