[ http://issues.apache.org/jira/browse/MYFACES-401?page=all ]
Martin Marinschek closed MYFACES-401:
-------------------------------------
Fix Version: Nightly Build
Resolution: Fixed
Don't think so: the first call to onsubmit is no call, but just a check if the
function is existing.
try out the following test file and see what happens:
<html>
<head>
</head>
<body>
<form id="form1" target="#" onsubmit="alert('executing onsubmit');return
false;">
<input type="submit"
onclick="if(document.forms['form1'].onsubmit){alert('checked onsubmit is
existing');
if(document.forms['form1'].onsubmit()){document.forms['form1'].submit();}}else{document.forms['form1'].submit();}return
false;}"/>
</form>
</body>
</html>
> CommandLink tag override onsubmit function of Form
> --------------------------------------------------
>
> Key: MYFACES-401
> URL: http://issues.apache.org/jira/browse/MYFACES-401
> Project: MyFaces
> Type: Bug
> Components: Implementation
> Versions: 1.1.0
> Environment: Tomcat 5.0.28
> Reporter: Zhong Li
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: Nightly Build
> Attachments: bugfix_myfaces-401.txt
>
> I have java script onsubmit in <h:form>, when I use commandLink tag, even
> onsubmit return false, the form still submitted. I checked javasctipt, If I
> am right, the bug should be here,
> JSF generate Javascript for each commandLink like,
> clear_unitItemViewList();
> document.forms['unitItemViewList'].elements['autoScroll'].value=getScrolling();
> document.forms['unitItemViewList'].elements['unitItemViewList:_link_hidden_'].value='unitItemViewList:_id49_0:_id72';
> if(document.forms['unitItemViewList'].onsubmit){document.forms['unitItemViewList'].onsubmit();}
> document.forms['unitItemViewList'].submit();
> return false;
> ----------------------
> so problem it will be caused by
> if(document.forms['unitItemViewList'].onsubmit){document.forms['unitItemViewList'].onsubmit();}
> document.forms['unitItemViewList'].submit(); //the form submitted!!!!!!
> it should be
> if(document.forms['unitItemViewList'].onsubmit)
> {
> if( document.forms['unitItemViewList'].onsubmit() )
> {
> document.forms['unitItemViewList'].submit();
> }
> }
> else
> {
> document.forms['unitItemViewList'].submit();
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
