[ http://issues.apache.org/jira/browse/MYFACES-628?page=comments#action_12331250 ]
Ronald Brill commented on MYFACES-628: -------------------------------------- Hi Bill > In the FacesServlet.service method I can wrap the call to lifecycle.render... from my point of view it's better to place the code in the LifecycleImpl. I think this makes the maintenance a bit easier. Otherwise you have to look at more then one place to understand the flow. BTW. please add a inline comment to the (different) check in the render method (maybe with a reference to the jira bug) > I figure you know the phase lifecycle well enough that I don't have to put > the 'next phase' into the message. Yes and no. I personally know this. But you dont have to pay for every single word of the debug messages. These are debug messages. So the intention is to help people to understand whats going on in case of trouble. Wy not helping the people as mutch as possible with this messages. And if someone new to faces mybe he/she likes this additional info (or this info prevents the support call). > Current Lifecycle implementation violates JSF Spec 1.1 > ------------------------------------------------------ > > Key: MYFACES-628 > URL: http://issues.apache.org/jira/browse/MYFACES-628 > Project: MyFaces > Type: Bug > Components: JSR-127 > Versions: 1.1.0 > Reporter: Holger Schimanski > Assignee: Bill Dudney > Priority: Blocker > Fix For: 1.1.1 > > If a PhaseListener.beforePhase() calles FacesContext.renderResponse() or > FacesContext.responseComplete(), then the LifeCycleImpl should not execute > the functionality required for the current phase. (see JSF Spec 1.1 section > 11-1 page 296f.) LifeCycleImpl is not taking care about this. > This is important for us, because we'd like to make a redirect in the before > render response phase. And at the moment an Illegal State exception is > thrown, because the renderResponse is executed although responseComplete has > been called. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
