[ http://issues.apache.org/jira/browse/MYFACES-701?page=comments#action_12356417 ]
Neal Haggard commented on MYFACES-701: -------------------------------------- As I stated in my fix, it would be nice if this was a possibility. While having three separate variables allows much flexibility, I imagine that in most cases, the user will store the script, style and image info in one directory like the other themes provided by MyFaces. My suggestion would be to add one attribute to the JSCookMenu & Tag, that is 'themeLocation'. This would be the base directory where you store your custom themes. So for instance, we store ours in '/jscookmenu/', then each custom theme is under there, like '/jscookmenu/TableAction/'. Due to the way AddResources ignores the base directory in determining if two scripts are equal (and don't need to be included twice), and the fact that ThemeName is a required attribute, I don't think the theme name should be included in the themeLocation attribute. This solution would allow those that want to fully override all aspects (from the base javascripts [jscookmenu.js, MyFacesHack.js] to the theme) to use the existing javascriptLocation, imageLocation, styleLocation. And those that just want to specify a custom theme to use the themeLocation attribute. I would be willing to help out with this if it is desired. Neal > Allow custom theme.js file without duplicating jscookmenu.js > ------------------------------------------------------------ > > Key: MYFACES-701 > URL: http://issues.apache.org/jira/browse/MYFACES-701 > Project: MyFaces > Type: Improvement > Components: Tomahawk > Versions: 1.1.1 > Reporter: Simon Kitching > Fix For: Nightly > > In release 1.1.0 and earlier, defining a custom theme for a jscookMenu > component was possible but rather clumsy. > Since the 1.1.0 release some code has been added to the jscookMenu component > to provide a new "javascriptLocation" attribute. > However it would appear that the "javascriptLocation" attribute is used to > locate the JSCookMenu.js and MyFacesHack.js files *as well as* the custom > theme's theme.js file. > Can this be separated into two different attributes? I would like to be able > to specify a theme.js file *without* having to extract the core files > "JSCookMenu.js" and "MyFacesHack.js" from the tomahawk jar and put them in > the same directory. > I think introducing a new attribute whose value is the URL of the custom > theme file is possible without causing any incompatibilities with prior > releases. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
