[ http://issues.apache.org/jira/browse/MYFACES-768?page=comments#action_12357173 ]
Simon Kitching commented on MYFACES-768: ---------------------------------------- Um .. I said above that the earlier patches were lost, but nope, there they are. Sorry, I took Martin's comment to mean the patch was committed and issue closed, which certainly discarded all the patches the first time around. Anyway, the "-2" patches include all the changes in the first patch files. > ReducedHTMLParser issues > ------------------------ > > Key: MYFACES-768 > URL: http://issues.apache.org/jira/browse/MYFACES-768 > Project: MyFaces > Type: Bug > Reporter: Simon Kitching > Assignee: Martin Marinschek > Fix For: Nightly > Attachments: ReducedHTMLParser.java.patch-2.txt, > ReducedHTMLParser.java.patch.txt, ReducedHTMLParserTest.java.patch.txt, > ReducedHTMLparserTest.java.patch-2.txt > > ReducedHTMLParser (used by AddResource class) currently fails to handle the > string "//-->". > I found that my script references were getting inserted right into the > middle of the body of my html page. After inserting some debug code, I > have found that > closedStartTag > is being called every time that "//-->" is encountered in the page. And > that's a lot, as that sequence is generated whenever an inline script is > inserted into the page. > This problem breaks every page containing a component that inserts > javascript into the page header (jscookmenu, HtmlTree, etc). > I've had a look at the code, and while the current implementation is very > small I think it's quite hard to read/debug/maintain and may not handle a > number of cases (such as the one described here). > Attached is a proposed alternative implementation of this class. The code is > larger but is hopefully easier to read. And also attached is a unit test case > class which the current implementation lacks. This class isn't *quite* > finished; the unit tests indicate there are a few off-by-one errors but > that's just a matter of tweaking. I hope that this may form the basis of a > replacement for the current ReducedHTMLParser. > The implementation is a hybrid state-machine/adhoc parser. > Regards, > Simon -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
