Yes, the NPE should be wrapped. I just no longer think the patch is a good idea because it means an end user could *not* specify their own Converter for java.lang.Serializable.
---- Original message ---- >Date: Fri, 16 Dec 2005 14:16:33 -0500 >From: Mike Kienenberger <[EMAIL PROTECTED]> >Subject: Re: [jira] Commented: (MYFACES-847) NPE w/ UpdateActionListener when @property is Serializable >To: MyFaces Development <[email protected]> >Cc: Dennis Byrne <[EMAIL PROTECTED]> > >Hey Dennis, > >I can certainly close this, but it sounds like you've found a valid >bug. I've never used UpdateActionListener, so I can't be sure. >From what I can tell, your patch doesn't seem to fix it, though. It >merely ignores the symptom. > >If nothing else, we should be throwing better errors rather than >having an NPE someplace. > >On 12/15/05, Dennis Byrne (JIRA) <[email protected]> wrote: >> [ http://issues.apache.org/jira/browse/MYFACES-847? page=comments#action_12360555 ] >> >> Dennis Byrne commented on MYFACES-847: >> -------------------------------------- >> >> Someone may want to close this, as the exception can be avoided by configuring a Converter. >> >> > NPE w/ UpdateActionListener when @property is Serializable >> > --------------------------------------------------------- - >> > >> > Key: MYFACES-847 >> > URL: http://issues.apache.org/jira/browse/MYFACES-847 >> > Project: MyFaces >> > Type: Bug >> > Components: Tomahawk >> > Versions: 1.1.1 >> > Reporter: Dennis Byrne >> > Priority: Minor >> > Attachments: myfaces.nov.18.2005.txt >> > >> > If the property attribute of t:updateActionListener evaluates to a property in a backing bean that is of type Serializable, the call to context.getApplication ().createConverter in UpdateActionListener.processAction() returns null. This results in a NPE at the bottom of processAction() . Patch attached. >> >> -- >> This message is automatically generated by JIRA. >> - >> If you think it was sent incorrectly contact one of the administrators: >> http://issues.apache.org/jira/secure/Administrators.jspa >> - >> For more information on JIRA, see: >> http://www.atlassian.com/software/jira >> >> Dennis Byrne
