[ 
http://issues.apache.org/jira/browse/MYFACES-983?page=comments#action_12361522 
] 

Peter Mahoney commented on MYFACES-983:
---------------------------------------

This check is not currently made in the month or week renderers. For 
consistency they should either all have the check or none, should they not? 
Also, given that parentForm is not actually used by the renderer, is it really 
the responsisbility of the renderer to check for the existence of the form?

Personally, I would remove the above check completely.

> Unnecessary check for UIForm component in ScheduleDetailedDayRenderer
> ---------------------------------------------------------------------
>
>          Key: MYFACES-983
>          URL: http://issues.apache.org/jira/browse/MYFACES-983
>      Project: MyFaces
>         Type: Bug
>     Versions: Nightly
>     Reporter: Peter Mahoney
>     Priority: Minor

>
> ScheduleDetailedDayRenderer includes the lines:
>         UIForm parentForm = getParentForm(schedule);
>         if (parentForm == null)
>         {
>             throw new NullPointerException("No parent UIForm found");
>         }
> However, if the schedule is readonly then the form component is not required 
> e.g. on a printable page.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to