I believe Bernd is correct. The changes were needed to allow the maven tests to work properly. We were able to resolve a circular dependency issue this way.
Sean On 1/15/06, Bernd Bohmann <[EMAIL PROTECTED]> wrote: > Ok, > > the StateUtils change is related maven stuff. > I have fixed some tests that doesn't work with maven. > Unfortunately one of my patches contains the try catch block. > This change restored the old state. > > Which comment should I add to my commit in this case? > > Regards > > Bernd > > Simon Kitching schrieb: > > Hi Bernd, > > > > Just a minor point... > > > > I see a patch was committed to change StateUtils as part of a patch > > containing maven-related work [r369027] by "bommel" which I think is > > you. However the changes to StateUtils doesn't seem to have anything to > > do with maven. > > > > As far as I can see, the actual change made is fine. It removes a > > try/catch clause which was simply ignoring the thrown exception, which > > is good as far as I'm concerned. And it does some whitespace cleanups. > > > > However I would have preferred to see this as a separate patch, with a > > useful associated comment, rather than as part of a commit for > > presumably completely unrelated maven stuff. > > > > Cheers, > > > > Simon > > > > > > -- > Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development > Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com > phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 >
