Hi Simon,
I would prefer to move the dependency to commons-collections to the impl
pom and not to copy the commons-collections code.
I think the dependency to commons-fileupload belongs to tomahawk.
And we should try to get a struts-tiles only dependency, but a
struts-tiles artifact is not available on a repository.
The struts has to many dependencies to other libs.
Maybe this aritifact is available with the upcoming 1.3 release.
If you like I will check in my proposed changes.
Regards
Bernd
Simon Kitching schrieb:
Hi,
File api/api/pom.xml has:
<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
<version>3.1</version>
<scope>compile</scope>
</dependency>
However as far as I can see, api has *no* dependency on
collections.Running the following returns nothing for api:
find . -name "*.java" \
-exec grep "org.apache.commons.collections" {} \; -print
So perhaps this dependency should be removed?
api/api/pom.xml also declares a compile-time dependency on file-upload.
Surely this can't be true! How about we remove this?
I've tried modifying the api/pom.xml file to remove both the collections
and file-upload dependency and everything builds fine.
On a similar topic, impl depends upon commons-collections in only one
place: JspStateManagerImpl depends upon ReferenceMap. Perhaps myfaces
should have its own implementation of this functionality to avoid a
dependency on collections? Requiring a whole jar for one class seems a
little excessive. Note that copying the collections ReferenceMap into
the myfaces namespace isn't simply as the ReferenceMap classes uses
several other collections classes - though probably for functionality
that myfaces never uses. Obviously there's a tradeoff; good to reuse
existing code, bad to duplicate. But also good to reduce dependencies
(particularly on libraries that other code may require a different
version of!).
Thanks,
Simon
--
Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development
Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com
phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333
