Ok, now that everything is stable again I am going to explain the reasons. I was going to send a mail after moving the classes and before doing anything else :)
With the current code, we cannot move f:view from where it is now, for instance now we cannot include the head inside the jsf markup. This could be solved moving the f:viewTag before the head, but this doesn't not work in myfaces because in our ResponseWriterImpl we write stuff (javascript for dummyForm, autoscroll...) when the viewTag is closed (ResponseWriter.endDocument()). We should move that code out of ResponseWriterImpl.endDocument() and put it in another place to be renderer just before the closing </body> tag. Alongside we will fix two important bugs (MYFACES-152 [1] and MYFACES-883 [2]) that hinders us to use adf-faces and facelets together with myfaces. We can use AddResource.java to write the stuff before the </body>. It has been moved to commons because we should call to this class from a base html renderer. Martin and I have been thinking that a good place to call to AddResource could be the viewTag component, although there are some issues against that as Jacob pointed out in a mail some time ago [3]. Our proposal is to (1) to create a document tag (just like in adf-faces) and call to AddResource from there and (2) also we could also render it in the f:view tag if the document tag is not included in the page. All this will solve those old bugs and we could have a new document tag which may simplify things. One new issue after moving the AddResource.java file and its dependencies to commons is that AddResourceTest uses some classes in myfaces-impl. I left AddResourceTest in tomahawk while we reach a solution for this. And of course, nothing has been decided, so thoughts and ideas welcome :-) Regards, Bruno [1] http://issues.apache.org/jira/browse/MYFACES-152 [2] http://issues.apache.org/jira/browse/MYFACES-883 [3] http://www.mail-archive.com/[email protected]/msg07873.html 2006/1/22, Bruno Aranda <[EMAIL PROTECTED]>: > Yes, you are right sorry. I first thought that only two classes were > involved, but after moving them my first priority was to stabilise > again the code base. I am going to explain everything now... > > 2006/1/22, Simon Kitching <[EMAIL PROTECTED]>: > > On Sun, 2006-01-22 at 21:27 +0100, Bruno Aranda wrote: > > > As you might have realised, I am moving the AddResource stuff to > > > commons. I am doing this because it will help to solve some old bugs > > > we have (such as MYFACES-152). I am going to explain this in detail > > > when I stabilise again the codebase after this moves. > > > > > > Thanks for your patience, > > > > I was quite surprised to see the commit messages moving this class. > > Perhaps some discussion first might have been a good idea? > > > > Regards, > > > > Simon > > > > >
