[ http://issues.apache.org/jira/browse/MYFACES-1034?page=comments#action_12365576 ]
Peter Mahoney commented on MYFACES-1034: ---------------------------------------- I thought there could be issues with that. Looking at it again, the ExtensionsFilter can pass an instance of ExternalContext to MyfacesConfig, like everything else. Not sure why I went down the ServletContext root. I will make the changes and submit another patch. > Allow customisable AddResource implementations > ---------------------------------------------- > > Key: MYFACES-1034 > URL: http://issues.apache.org/jira/browse/MYFACES-1034 > Project: MyFaces > Type: Improvement > Components: Tomahawk > Versions: Nightly > Reporter: Peter Mahoney > Assignee: Martin Marinschek > Attachments: AddResourcePatch.zip, DefaultAddResource.java, > addresource_patch3.zip > > I use an alternative version of the AddResource. class > The two areas which I have customised are the getResourceUri() method (which > rewrites the URL to call resources through a forwarding controller servlet) > and writeWithFullHeader() (which has different rules as to where insertions > will take place when there is no <head> or <body> tags, as the applications > only output HTML fragments). > Currently to do this a custom MyFaces has to be built. > Ideally, AddResource would be an interface. An AddResourceFactory class would > provide the getInstance() method (or equivalent). This method would check for > a context parameter specifying the implementation class to use. If not > specified, an instance of DefaultAddResource would be used. > DefaultAddResource would be non-final and would therefore be subclassed to > provide the customisations described above. > Would this be a suitable change? If so, I would be happy to implement the > change and supply a patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
