First, I don't like the master pom.
Every subproject should have his own pom.
But this is an other question.
Sean Schofield schrieb:
Q1. Regarding the maven sub-project: Why do build-tools and master-pom
have no parent relationship to the maven-project pom?
There is nothing that needs to really be shared between the two. More
importantly, since every other subproject starts out with the
master-pom, you would basically require all of
those projects to depend on the maven-project pom. This would be
another extra artifact that you would have to publish and maintain
(for no good reason.)
Q2. What exactly is the build-tools module for? Checkstyle is not used
yet, right?
Tobago is using checkstyle and for a multi module setup you need one
artifact for the common configuration of your checkstyle and pmd and
maybe other plugins.
I will let Bernd answer that one.
Q3. Why does the site pom have no parent relationship to the
myfaces-master pom? Seems to contain lots of redundant information
which could be derived from master pom.
If the site is a parent of the master pom it would be distributed to
the url of the master pom plus the artifactId.
For example the site in master pom is
minotaur.apache.org/www/myfaces.apache.org
the site would be distibuted to
minotaur.apache.org/www/myfaces.apache.org/${artifactId}
Without a parent the artifactId is not appended to the site url.
I want to know the answer to this one too ;-) It did have this
reference just a few days ago until things were breaking. Bernd
somehow go it to work by removing this ref. I've asked him to explain
how this works. We definitely need to go back to using the master-pom
though. That was one of the main reasons for having it (so we didn't
need to maintain dual lists.)
Q4. What is commons/src/site? Is this zombie code?
No. Its the commons portion of the site. There is no description yet
but I am writing one up as we speak.
Q5. The module name "wagon-maven-plugin" is a bit confusing IMHO.
Should't we call it "myfaces-maven-wagon-plugin" or something like
that to point out that this is no standard or codehaus sandbox plugin?
It is a simple wagon wrapper. It has nothing to do with myfaces only it
copies the content of a dir to an other server per ssh. Maybe
myfaces-maven-wagon-plugin would be a better name but the plugin is not
myfaces specific. Maybe we should post it on codehaus but I have not the
time to support this plugin.
Maybe but its already released now. Hopefully it can be abandoned
eventually once we get the official maven ones to do what we need.
Ask Bernd about the name choice.
Q6. Why do assembly sub-modules exist? Is there any issue that
prevents us from adding the assembly configuration into the modules
pom itself?
Does the assembly only contains the artifact of this module you would be
right. But if is an assembly of a set of artifacts it should an own
module. And with an own pom you can define the content per dependency
section.
Bernd can answer this one. He is more knowledgeable about maven.
Q7. AFAIK the scm config is not needed within sub-modules. Maven
calculates the right SVN URLs. So, any objections against removing scm
config from core/api, core/impl, tomahawk/core etc. ?
Yes I object. It won't work. This only works if your artifacts have
the same name as your directories. So we would have to name our
directories myfaces/core/myfaces-api instead of myfaces/core/api.
Bernd
